Skip to content

fix(desktop): prevent env var leak in persistent terminal subprocess #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kitenite merged 1 commit into from
Jan 17, 2026
Merged

fix(desktop): prevent env var leak in persistent terminal subprocess #785

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions apps/desktop/src/main/terminal-host/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,14 +180,11 @@ export class Session {
const shellArgs = this.getShellArgs(this.shell);
const subprocessPath = path.join(__dirname, "pty-subprocess.js");

// Use electron as node to run the subprocess
// Spawn subprocess with filtered env to prevent leaking NODE_ENV etc.
const electronPath = process.execPath;
this.subprocess = spawn(electronPath, [subprocessPath], {
stdio: ["pipe", "pipe", "inherit"], // pipe stdin/stdout, inherit stderr
env: {
...process.env,
ELECTRON_RUN_AS_NODE: "1",
},
stdio: ["pipe", "pipe", "inherit"],
env: { ...processEnv, ELECTRON_RUN_AS_NODE: "1" },
});

// Read framed messages from subprocess stdout
Expand Down
Loading