Skip to content

fix(trpc): suppress NOT_FOUND errors in onError handler #4534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saddlepaddle merged 2 commits into from
May 14, 2026
+4 −0
Merged

fix(trpc): suppress NOT_FOUND errors in onError handler #4534

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9de1efc
fix(trpc): suppress NOT_FOUND errors in onError handler
May 14, 2026
520d82d
fix(trpc): scope NOT_FOUND suppression to device.heartbeat path only
May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/api/src/app/api/trpc/[trpc]/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ const handler = (req: Request) =>
router: appRouter,
createContext,
onError: ({ path, error }) => {
// Suppress NOT_FOUND only for the known-dead device.heartbeat path
// (removed in #4490). Old desktop clients gated behind UpdateRequiredPage
// still call it; all other NOT_FOUND errors should remain visible.
if (error.code === "NOT_FOUND" && path === "device.heartbeat") return;
console.error(`❌ tRPC error on ${path ?? "<no-path>"}:`, error);
},
});
Expand Down
Loading