From 035437b251be185bc0cf29f53396534597ba0991 Mon Sep 17 00:00:00 2001
From: Kiet Ho <hoakiet98@gmail.com>
Date: Sat, 18 Apr 2026 11:41:36 -0700
Subject: [PATCH] fix(desktop): show spinner on install update button while
 pending
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Disabled state alone didn't feel responsive — click registered without
obvious acknowledgement. Adds a spinning icon alongside the existing
"Installing..." label so users see the action was received.
---
 .../components/UpdateRequiredPage/UpdateRequiredPage.tsx     | 4 ++++
 .../src/renderer/components/UpdateToast/UpdateToast.tsx      | 5 ++++-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/apps/desktop/src/renderer/components/UpdateRequiredPage/UpdateRequiredPage.tsx b/apps/desktop/src/renderer/components/UpdateRequiredPage/UpdateRequiredPage.tsx
index af5ab804bcb..c6c4a763306 100644
--- a/apps/desktop/src/renderer/components/UpdateRequiredPage/UpdateRequiredPage.tsx
+++ b/apps/desktop/src/renderer/components/UpdateRequiredPage/UpdateRequiredPage.tsx
@@ -90,7 +90,11 @@ export function UpdateRequiredPage({
 							<Button
 								onClick={handleInstall}
 								disabled={installMutation.isPending}
+								className="gap-2"
 							>
+								{installMutation.isPending && (
+									<HiArrowPath className="h-4 w-4 animate-spin" />
+								)}
 								{installMutation.isPending
 									? "Installing..."
 									: "Install & Restart"}
diff --git a/apps/desktop/src/renderer/components/UpdateToast/UpdateToast.tsx b/apps/desktop/src/renderer/components/UpdateToast/UpdateToast.tsx
index 85f54a6d631..9eeed7d2af2 100644
--- a/apps/desktop/src/renderer/components/UpdateToast/UpdateToast.tsx
+++ b/apps/desktop/src/renderer/components/UpdateToast/UpdateToast.tsx
@@ -1,7 +1,7 @@
 import { COMPANY } from "@superset/shared/constants";
 import { Button } from "@superset/ui/button";
 import { toast } from "@superset/ui/sonner";
-import { HiMiniXMark } from "react-icons/hi2";
+import { HiArrowPath, HiMiniXMark } from "react-icons/hi2";
 import { electronTrpc } from "renderer/lib/electron-trpc";
 import { AUTO_UPDATE_STATUS } from "shared/auto-update";
 
@@ -93,6 +93,9 @@ export function UpdateToast({
 						onClick={handleInstall}
 						disabled={installMutation.isPending}
 					>
+						{installMutation.isPending && (
+							<HiArrowPath className="size-3.5 animate-spin" />
+						)}
 						{installMutation.isPending ? "Installing..." : "Install"}
 					</Button>
 				</div>