-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stars don't come out at night #8
Comments
I will try it on a macbook asap. Stars are very very small on purpose so in VR mode they feel right. Maybe in your screen they are rendered too small to preceive but they are ok in vr mode? thanks! |
It works great for me. 1080 card. |
Oh, I thought mine had an Intel. It's an old macbook, GeForce 9400M, works fine. |
Yeah, I can just barely see them when I switch to a lower-DPI display. Maybe the star size could be configurable, or somehow adapt to the display. |
hmm.. the important scenario is when you are in VR, when they have to look nice. I'll think about what would be the best solution.. Configurable size does not seem very useful.. Do they look ok in-VR for you? are you making a only-2d experience? Thanks! |
The demo I'd like to use this for is supposed to highlight the versatility of WebVR, so it's designed to work on 2D desktop, Google Cardboard, and HTC Vive. There's a good chance we'll support Daydream and GearVR too. We're currently using a texture map for the stars in our scene, but it's not corrected for distortion, so it's a bit ugly at the zenith. |
I see. Thanks for sharing. My concern now is that stars are currently squares, so if you make them bigger they will look bad. I'll try to use small rounded sprites and add a size parameter. |
I wonder if it's possible to auto-adjust the size based on the DPI of the device. |
is this still needed? |
The stars are not visible with the latest code in Chrome or Firefox on my machine, a Macbook with Intel HD 5000 graphics. To reproduce, I just have to go to the "starry" preset in the demo application.
The text was updated successfully, but these errors were encountered: