Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions, remove Travis #16

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dyfer
Copy link
Member

@dyfer dyfer commented Aug 1, 2021

As travis-ci.org no longer works, I've moved the build to GitHub Actions, which is what we've done with the main SuperCollider repository some time ago.

Points to consider:

  • build system is newer than on Travis; it runs on macOS 10.15. I've set it to use XCode 10.3 (the oldest available version - I've chosen this for possibly best compatibility, but we can of course change that)
  • build artifacts are now accessible for each build ("Actions" tab on GitHub - registered GH users only)
  • testing SCAU with auval fails for reasons not related to this PR, AFAICT (see here)
  • failing tests is set to not abort the entire build; i.e. artifacts are still uploaded even if tests fail.
  • if a commit is tagged, the build will be uploaded to GitHub Releases; before deciding to make a proper release we might want to include more information in the zip file (Readme etc), but that's out of the scope of this PR. For now I just wanted to provide basic infrastructure for automated releases. Test release can be found here: https://github.com/dyfer/SuperColliderAU/releases/tag/0.0.1-test

EDIT: I don't think the new GitHub Actions will run until this is merged. Proper run can be observed on my fork.

@dyfer dyfer requested a review from g-roma August 2, 2021 00:21
@g-roma
Copy link
Member

g-roma commented Aug 7, 2021

Hi, thanks for the PR. I'll use the opportunity to review the project a bit. I had not seen the auval error before, but seems quite understandable, since that parameter is changed programatically by design. We'll see if there is any solution to that. OTOH, the idea of generating releases is nice, but it is important that the corresponding SC version is known, etc. In any case I am certainly open to trying it, so I expect to merge this soon.

@dyfer
Copy link
Member Author

dyfer commented Aug 7, 2021

Thanks!
As for releases/project review, I'd want to add that I hope at some point that we refactor SuperCollider's CMake, so that one can build plugins only for SCAU, without building whole SC... I think we'd need to also import SCVersion somehow, but I think this mostly needs the (planned, but no timeline) CMake rewrite.

@dyfer
Copy link
Member Author

dyfer commented Feb 27, 2022

Hi @g-roma
Any updates on this? Is there anything I can do to help with the process of reviewing/merging this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants