Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush unused buckets out of memory #268

Open
shtlrs opened this issue Mar 25, 2024 · 0 comments
Open

Flush unused buckets out of memory #268

shtlrs opened this issue Mar 25, 2024 · 0 comments

Comments

@shtlrs
Copy link
Contributor

shtlrs commented Mar 25, 2024

The rate limiting solution uses the process' memory to store the token buckets.

If for some reason, the service becomes popular and a lot of clients target it, the number of buckets will start to grow, and so does the memory consumption.

I think that we should timestamp the buckets with the time they were last used, and have a background job like reap that runs every N seconds to flush the stale buckets out of memory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant