feat: add get_vault_secret_by_name() function
#335
Merged
+59
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR is to add
get_vault_secret_by_name()function in the framework, so fdws can use it to retrieve a secret from Vault by name. This PR will fix #284 .What is the current behavior?
Currently the Vault secret can only be retrieved by id, which is inconvenient using with db migrations.
What is the new behavior?
Added a new
get_vault_secret_by_name()function in the framework, so downstream fdws can use it to retrieve a secret from Vault by name.Additional context
Stripe FDW has been updated in this PR to add a new server option
api_key_name, which used the newget_vault_secret_by_name()function.