fix: reset state when begin scan #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test failed due to this ClickHouse issue: ClickHouse/ClickHouse#60020 |
imor
approved these changes
Feb 16, 2024
ci: remove clickhouse init db
…nto fix/scan-state-reset
kamyshdm
pushed a commit
to dymium-io/supabase-wrappers
that referenced
this pull request
Jun 17, 2024
[#supabase#238] Enforce unique name in jsonb
kamyshdm
pushed a commit
to dymium-io/supabase-wrappers
that referenced
this pull request
Jun 17, 2024
…s from 95239dd..5b5c262 5b5c262 Merge pull request supabase#233 from supabase/chore/use_create_async_runtime ee74f6e Merge pull request supabase#239 from supabase/fix/scan-state-reset 42aa7e1 Merge branch 'fix/scan-state-reset' of github.com:supabase/wrappers into fix/scan-state-reset 8c2d58e fix: reset state when begin scan 5e398a3 Merge pull request supabase#241 from supabase/ci/clickhouse-init-db 6967050 format test code 72012b6 ci: remove clickhouse init db cfe70d1 fix: reset state when begin scan c169e7e chore(s3): revert use create_async_runtime() 0788612 chore(s3): use existing create_async_runtime() git-subtree-dir: DbGuardian/foreign_data_wrappers/supabase_wrappers git-subtree-split: 5b5c262
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR is to add state reset code when begin a scan, this can partially fix #237.
What is the current behavior?
The foreign table scan execution plan will be cached when foreign table query is defined in a function, this will result in
begin_scan()being called without callingnew()function, which is supposed to re-initialise the FDW instance.What is the new behavior?
Added some state reseting codes in
begin_scan()for some FDWs, so that their inner state will be reset correctly.Additional context
This PR can partially fix #237, so the continuous foreign table function call should be correct. But for permanent fix, we need to find out better way to manage and re-use
FdwState.