fix(supabase)!: make Supabase credentials private in SupabaseClient
#649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshukertjr
changed the title
dshukertjr
changed the title
SupabaseClient private
dshukertjr
commented
Oct 1, 2023
Comment on lines
-102
to
-118
| /// Creates a Supabase client to interact with your Supabase instance. | ||
| /// | ||
| /// [supabaseUrl] and [supabaseKey] can be found on your Supabase dashboard. | ||
| /// | ||
| /// You can access none public schema by passing different [schema]. | ||
| /// | ||
| /// Default headers can be overridden by specifying [headers]. | ||
| /// | ||
| /// Custom http client can be used by passing [httpClient] parameter. | ||
| /// | ||
| /// [storageRetryAttempts] specifies how many retry attempts there should be to | ||
| /// upload a file to Supabase storage when failed due to network interruption. | ||
| /// | ||
| /// [realtimeClientOptions] specifies different options you can pass to `RealtimeClient`. | ||
| /// | ||
| /// Pass an instance of `YAJsonIsolate` to [isolate] to use your own persisted | ||
| /// isolate instance. A new instance will be created if [isolate] is omitted. |
There was a problem hiding this comment.
This chunk of comment is included in the macro below.
dshukertjr
changed the title
SupabaseClient privateSupabaseClient private
|
I really like the new tests! But I think we should keep rest and realtime public. Some might do some heavy channel management via the realtime object and the headers should be editable per sub library as concluded here |
dshukertjr
changed the title
SupabaseClient privateSupabaseClient
|
@Vinzent03 Thanks for the reminder. Made |
Vinzent03
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Make the following private, because users shouldn't need to access them using the client library.
realtime(RealtimeClient instance)rest(PostgrestClient instance)Additional context
I feel like there might have been a use case where the
restneeded be public, but I cannot find the issue that had context about it. I feel like it had something to do with headers, which I think should now be solved since we expose a setter, but if anyone has a use cases for any of these to be public, please do let me know!Edited:
Not making
restandrealtimeprivate #649 (comment)