Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: bump minimum Dart SDK version to 2.17.0 #510

Merged
merged 4 commits into from
Jun 12, 2023

Conversation

dshukertjr
Copy link
Member

@dshukertjr dshukertjr commented Jun 11, 2023

What kind of change does this PR introduce?

  • Bumps the minimum Dart SDK version to 2.17.0 across all packages
  • Also removed the extension methods on Enums to add name getter.

@dshukertjr dshukertjr changed the title refactor: bump minimum Dart SDK version to 2.17.0 across all the packages refactor: bump minimum Dart SDK version to 2.17.0 Jun 11, 2023
@Vinzent03
Copy link
Collaborator

Does that mean the next version is 2.0.0 and the main branch gets the other breaking changes?

@dshukertjr
Copy link
Member Author

dshukertjr commented Jun 12, 2023

@Vinzent03 It feels weird why not, and I've thought it is considered breaking change when changing the minimum required version, but we are not bumping the major version as packages bump minimum required SDK all the time without bumping the major versions. https://pub.dev/packages/cloud_firestore/changelog#470

@dshukertjr dshukertjr merged commit ed927ee into main Jun 12, 2023
@dshukertjr dshukertjr deleted the refactor/sdk-version branch June 12, 2023 00:50
@Vinzent03
Copy link
Collaborator

Okay, thanks for explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants