Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add version env to dockerfile #377

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix: add version env to dockerfile #377

merged 1 commit into from
Oct 9, 2023

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Oct 9, 2023

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

VERSION env is not passed into the container via build args

What is the new behavior?

assign VERSION env from build-args VERSION

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Pull Request Test Coverage Report for Build 6459136527

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.913%

Totals Coverage Status
Change from base Build 6453825009: 0.0%
Covered Lines: 7432
Relevant Lines: 8789

💛 - Coveralls

@fenos fenos merged commit 37d0573 into master Oct 9, 2023
1 check passed
@fenos fenos deleted the fix/version-dockerfile branch October 9, 2023 16:16
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

🎉 This PR is included in version 0.43.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants