Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): type result for throwOnError responses #590

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix(types): type result for throwOnError responses #590

wants to merge 4 commits into from

Conversation

avallete
Copy link
Member

@avallete avallete commented Jan 7, 2025 •
edited
Loading

When using throwOnError(), the response type is now more strictly typed:

  • Data is guaranteed to be non-null
  • Response type is controlled by generic ThrowOnError boolean parameter

Fixes #563

@avallete
fix(types): type result for throwOnError responses
c142420 
When using throwOnError(), the response type is now more strictly typed:
- Data is guaranteed to be non-null
- Error field is removed from response type
- Response type is controlled by generic ThrowOnError boolean parameter

Fixes #563
@avallete avallete requested a review from soedirgo January 7, 2025 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soedirgo soedirgo Awaiting requested review from soedirgo

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.throwOnError() doesn't do typecheck
1 participant
@avallete