Target ES2017 in tsconfig #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soedirgo
approved these changes
Jan 18, 2023
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that my Typescript was complaining because code in
PostgrestFilterBuilderusesObject.entries, which is an ES2017 method, but Typescript was only targeting ES2015.AFAIK ES2017 is supported by all modern browsers, so I suggest just bumping the target. You can see here for some compatibility tables: https://kangax.github.io/compat-table/es2016plus/
If you really like targeting ES2015 for a reason I don't know, you could leave the target alone and use the
libproperty to express that you expect ES2017 library functions to exist: https://www.typescriptlang.org/tsconfig#lib