increase min sunpy #63

nabobalis · 2024-07-23T23:27:07Z

This supersedes #48

Fixes Add towncrier #49
Renamed FortranTracer to PerformanceTracer
Deprecated FortranTracer
streamtracer is now a hard dep
Deprecated bunch of utils I think we don't need anymore.
Bunch of package updates
Trying to tidy up the example gallery
Adaptmap removed due to upstream support in sunpy

This turned into a large PR. I could split it out but i'm lazy.

sunkit_magex/pfss/tests/test_pfss.py

nabobalis · 2024-07-24T01:18:34Z

sunkit_magex/pfss/utils.py

-        hmi_map.meta.update(_earth_obs_coord_meta(hmi_map.meta['date-obs']))
-
-
-def load_adapt(adapt_path):


We dont have the same loader in sunpy but we can now load them directly. But only the first one.

I personally use load_adapt almost every day i do research with sunkit-magex and send people examples which use it. It's very useful to be able to in one line get all the realizations loaded into a Map and then decide what to do next (choose one, average them all etc.), so i'd advocate that this function would be useful to have somewhere. I get that handling specific magnetograms doesn't make sense to be the job of sunkit-magex - could it be possible to house it in sunpy.map ? Is the direct use of astropy.io.fits problematic?

In any case, I'm good with this being deprecated for now and having this discussion elsewhere. Is it bad practise to have a long message here. if not, I suggest :

message = "Use sunpy.map.Map to load the first realization (see <link to examples/utils/reproject_car_to_cea.py>) or see https://docs.sunpy.org/en/latest/generated/gallery/saving_and_loading_data/load_adapt_fits_into_map.html on how to load all realizations"

Maybe the example can be updated to have the load_funciton or maybe it could be in sunpy but for me it does not belong in magex.

examples/using_sunkit_magex_pfss/overplotting_onto_aia.py

sunkit_magex/pfss/input.py

nabobalis · 2025-02-05T00:20:50Z

pyproject.toml

+  "scipy>=1.10.1",
+  "streamtracer>=2.2.0",
+  "sunpy[map]>=6.0.1,!=6.0.0",
+  "matplotlib>=3.5.0",  # Needed to solve the correct env for oldestdeps


I didn't know how else to handle it

sunkit_magex/pfss/analytic.py

sunkit_magex/pfss/tests/test_analytic.py

STBadman

Almost everything looks good except the deprecation of FortranTracer looks to be broken - it's inheriting a child Class and as I understand it, this needs to be passed to .super()

Otherwise, I'm ok with load_adapt and fix_hmi_meta being deprecated and discussion of any gaps in capability moving to sunpy.

Thanks for all this work!

sunkit_magex/pfss/tracing.py

sunkit_magex/pfss/tests/test_analytic.py

sunkit_magex/pfss/input.py

STBadman · 2025-02-07T16:02:32Z

docs/performance.rst

@@ -11,9 +11,8 @@ To enable this simply `install numba`_  and use `sunkit_magex.pfss` as normal.
 Streamline tracing
 ==================

-`sunkit_magex.pfss` has two streamline tracers: a pure python `sunkit_magex.pfss.tracing.PythonTracer` and a complied tracer `sunkit_magex.pfss.tracing.FortranTracer`.
-The compiled version is significantly faster, using the `streamtracer`_ package.
+`sunkit_magex.pfss` uses a complied tracer `sunkit_magex.pfss.tracing.PerformanceTracer` using the `streamtracer`_ package.


I think since we're not removing the pythontracer and there isn't a default behavior implemented anywhere yet we should still mention it here, like it was originally but just change FortranTracer to PerformanceTracer in the old line 14,

examples/testing/field_line_error_map.py

sunkit_magex/pfss/analytic.py

STBadman · 2025-02-07T17:40:27Z

sunkit_magex/pfss/utils.py

-        hmi_map.meta.update(_earth_obs_coord_meta(hmi_map.meta['date-obs']))
-
-
-def load_adapt(adapt_path):


I personally use load_adapt almost every day i do research with sunkit-magex and send people examples which use it. It's very useful to be able to in one line get all the realizations loaded into a Map and then decide what to do next (choose one, average them all etc.), so i'd advocate that this function would be useful to have somewhere. I get that handling specific magnetograms doesn't make sense to be the job of sunkit-magex - could it be possible to house it in sunpy.map ? Is the direct use of astropy.io.fits problematic?

In any case, I'm good with this being deprecated for now and having this discussion elsewhere. Is it bad practise to have a long message here. if not, I suggest :

message = "Use sunpy.map.Map to load the first realization (see <link to examples/utils/reproject_car_to_cea.py>) or see https://docs.sunpy.org/en/latest/generated/gallery/saving_and_loading_data/load_adapt_fits_into_map.html on how to load all realizations"

sunkit_magex/pfss/utils.py

nabobalis · 2025-03-13T21:46:33Z

I think have addressed all of your points/questions @STBadman.

nabobalis · 2025-03-13T22:06:21Z

pyproject.toml

-  "sunpy[map]>=5.1",
+  "scipy>=1.10.1",
+  "streamtracer>=2.2.0",
+  "git+https://github.com/nabobalis/sunpy.git@database",


This is me testing a commit to see if I can fix the database.

nabobalis · 2025-03-13T23:20:58Z

Oh I am confused, sunpy doesn't change the meta anymore. If you access the attributes of the map, those should be correct now. I think .units?

Hm, I don't know. But I just checked and run some old code that uses fix_hmi_meta. I run it with applying fix_hmi_meta and also without (i.e., just loading the HMI file with sunpy). The resulting figures look the same, only in the latter case, some SunpyMetadataWarning are printed:

Missing metadata for solar radius: assuming the standard radius of the photosphere. [sunpy.map.mapbase]
2024-09-17 18:19:50 - sunpy - INFO: Missing metadata for solar radius: assuming the standard radius of the photosphere.
WARNING: SunpyMetadataWarning: Missing metadata for observer: assuming Earth-based observer.
For frame 'heliographic_stonyhurst' the following metadata is missing: hgln_obs,hglt_obs,dsun_obs
For frame 'heliographic_carrington' the following metadata is missing: crlt_obs,dsun_obs,crln_obs
 [sunpy.map.mapbase]
2024-09-17 18:19:50 - sunpy - WARNING: SunpyMetadataWarning: Missing metadata for observer: assuming Earth-based observer.
For frame 'heliographic_stonyhurst' the following metadata is missing: hgln_obs,hglt_obs,dsun_obs
For frame 'heliographic_carrington' the following metadata is missing: crlt_obs,dsun_obs,crln_obs

Which HMI files were causing these warnings?

jgieseler · 2025-03-14T07:21:08Z

Which HMI files were causing these warnings?

It might be 2021-04-17 13:04 (mrzqs210417t1304c2243_256.fits). At least I modified that file close to when writing my message here (and the April 17 event is quite often my default setting).

STBadman

Thank you @nabobalis - I think it's in good shape!

nabobalis · 2025-04-09T16:27:29Z

Thanks everyone

STBadman · 2025-04-09T19:02:47Z

Thank you @nabobalis !

nabobalis force-pushed the sunpy_version branch 3 times, most recently from 3b12579 to d4d8d35 Compare July 24, 2024 00:09

nabobalis marked this pull request as draft July 24, 2024 00:09

nabobalis marked this pull request as ready for review July 24, 2024 00:10

nabobalis marked this pull request as draft July 24, 2024 00:10

nabobalis force-pushed the sunpy_version branch 4 times, most recently from 1ba30c9 to d28706f Compare July 24, 2024 01:17

nabobalis commented Jul 24, 2024

View reviewed changes

sunkit_magex/pfss/tests/test_pfss.py Show resolved Hide resolved

nabobalis commented Jul 24, 2024

View reviewed changes

sunkit_magex/pfss/tests/test_pfss.py Show resolved Hide resolved

nabobalis commented Jul 24, 2024

View reviewed changes

nabobalis force-pushed the sunpy_version branch from d28706f to 23a1392 Compare July 24, 2024 01:53

This comment was marked as outdated.

Sign in to view

nabobalis force-pushed the sunpy_version branch 5 times, most recently from 6af00f1 to bfacbe8 Compare July 24, 2024 22:44

nabobalis commented Jul 24, 2024

View reviewed changes

examples/using_sunkit_magex_pfss/overplotting_onto_aia.py Outdated Show resolved Hide resolved

nabobalis force-pushed the sunpy_version branch 5 times, most recently from 2d7c5db to 1f03469 Compare July 25, 2024 19:51

nabobalis commented Jul 25, 2024

View reviewed changes

sunkit_magex/pfss/input.py Show resolved Hide resolved

nabobalis marked this pull request as ready for review July 25, 2024 19:52

This comment was marked as outdated.

Sign in to view

nabobalis requested a review from Cadair August 22, 2024 19:54

nabobalis force-pushed the sunpy_version branch from 5eb8e40 to 9552abf Compare February 4, 2025 22:14

nabobalis commented Feb 5, 2025

View reviewed changes

sunkit_magex/pfss/analytic.py Outdated Show resolved Hide resolved

nabobalis commented Feb 5, 2025

View reviewed changes

sunkit_magex/pfss/tests/test_analytic.py Show resolved Hide resolved

STBadman requested changes Feb 7, 2025

View reviewed changes

nabobalis added 8 commits March 13, 2025 14:30

increase min sunpy

d9e3453

Handle old functions and update examples

d5033bc

bug in sunpy 6.0.0 means we need to wait for bugfix release

3dd7625

CR

6ecf02a

Fix scipy dep warning

ca2cbeb

Update URL for example

9355825

fix oldestdeps

c5c6758

Actually fix example

5ca9721

nabobalis mentioned this pull request Mar 13, 2025

Add Earth Observator to all SDO maps? sunpy/sunpy#8127

Open

Fix code review issues

bd4b028

nabobalis force-pushed the sunpy_version branch from 7a178f9 to bd4b028 Compare March 13, 2025 21:39

nabobalis mentioned this pull request Mar 13, 2025

Updates from package template #93

Merged

nabobalis commented Mar 13, 2025

View reviewed changes

Revert

8347d80

nabobalis force-pushed the sunpy_version branch from 4eab7bf to 8347d80 Compare March 13, 2025 22:16

less toc

dead408

STBadman approved these changes Mar 18, 2025

View reviewed changes

nabobalis merged commit 5bf2a62 into main Apr 9, 2025
11 of 13 checks passed

nabobalis deleted the sunpy_version branch April 9, 2025 16:27

nabobalis removed the request for review from jgieseler April 9, 2025 16:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

increase min sunpy #63

increase min sunpy #63

nabobalis commented Jul 23, 2024 •

edited

Loading

nabobalis Jul 24, 2024

This comment was marked as outdated.

nabobalis Jul 24, 2024

STBadman Feb 7, 2025

nabobalis Mar 13, 2025

This comment was marked as outdated.

This comment was marked as outdated.

nabobalis Feb 5, 2025

STBadman left a comment

STBadman Feb 7, 2025

STBadman Feb 7, 2025

nabobalis commented Mar 13, 2025

nabobalis Mar 13, 2025

nabobalis commented Mar 13, 2025

jgieseler commented Mar 14, 2025 •

edited

Loading

STBadman left a comment

nabobalis commented Apr 9, 2025

STBadman commented Apr 9, 2025

		hmi_map.meta.update(_earth_obs_coord_meta(hmi_map.meta['date-obs']))


		def load_adapt(adapt_path):

increase min sunpy #63

increase min sunpy #63

Conversation

nabobalis commented Jul 23, 2024 • edited Loading

Choose a reason for hiding this comment

This comment was marked as outdated.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as outdated.

This comment was marked as outdated.

Choose a reason for hiding this comment

STBadman left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nabobalis commented Mar 13, 2025

Choose a reason for hiding this comment

nabobalis commented Mar 13, 2025

jgieseler commented Mar 14, 2025 • edited Loading

STBadman left a comment

Choose a reason for hiding this comment

nabobalis commented Apr 9, 2025

STBadman commented Apr 9, 2025

nabobalis commented Jul 23, 2024 •

edited

Loading

jgieseler commented Mar 14, 2025 •

edited

Loading