Add puppeteer to whitelist

[sungshon]

I would love to make puppeteer available to add-on devs, instead of the horrible little phantomjs module that is currently available.

I'll just write my thoughts about this here until I get to a point where this is actually doable.

Why move away from phantomjs?

• it's old, abandoned and doesn't work efficiently on all sites
• does not support ES 5/6 (although we have logic that adds a shim for them if polyfill is set to true

Why did we even use it in the first place then?

• because the phantomjs binary is 40-50mb, while the bundled chromium of puppeteer is a staggering 300mb
• because it still works in many scenarios

What would be the solution to this mess?

The solution would be to use prebuilt chromium binaries that were built with headless_shell. This would (hopefully) drastically reduce it's size.

But puppeteer has no setting to get headless_shell prebuilts, and building chromium myself for all OSs would most probably be a hellish task, not to mention the fact that it would not be trustworthy, it should be gotten from an official source.

One issue thread seems to suggest there are official headless_shell builds, example:
https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/583214/headless-shell.zip

Related issues on puppeteer:
puppeteer/puppeteer#3155
puppeteer/puppeteer#3140
puppeteer/puppeteer#3027
puppeteer/puppeteer#500

[sungshon]

Adding puppeteer will cause the same issues that phantomjs is currently causing for Android:
#51

So I'll probably drop this ticket soon.

[sungshon]

An update on this:

The solution would be to use prebuilt chromium binaries that were built with headless_shell. This would (hopefully) drastically reduce it's size.

Puppeteer currently uses Chromium revision 722234, and headless_shell only has prebuilts for Linux. So using the headless build is still not a solution, and probably won't be a solution for the near future either.

Chromium prebuilt links:

• Chromium Linux, revision 722234
• Chromium Windows, revision 722234
• Chromium OSX, revision 722234

[sungshon]

I've changed my mind, will try to replace phantomjs with puppeteer.

Check this comment for details: #51 (comment)

[sungshon]

I've changed my mind again, we can't reproduce the puppeteer API to work remotely efficiently. So I won't add puppeteer to PimpMyStremio, but will leave this ticket open for now in case things change again.