Perform relocations using inline asm. #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunfishcode
force-pushed
the
sunfishcode/relocate-using-asm
branch
from
e462aee to
7cadee0
Compare
sunfishcode
force-pushed
the
sunfishcode/relocate-using-asm
branch
2 times, most recently
from
780ce8f to
9e031bc
Compare
Use inline asm to to the loads and stores needed by the relocation logic, which happen outside the Rust memory model. This is conceptually cleaner than using inline-asm to obscure the operands and result values of the loads and stores, as it puts the actual memory access outside of the scope of Rust.
sunfishcode
force-pushed
the
sunfishcode/relocate-using-asm
branch
from
9e031bc to
d94a047
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use inline asm to to the loads and stores needed by the relocation logic, which happen outside the Rust memory model. This is conceptually cleaner than using inline-asm to obscure the operands and result values of the loads and stores, as it puts the actual memory access outside of the scope of Rust.