-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Brevo types/config and deprecate usage of Sendinblue #374
base: 2.5
Are you sure you want to change the base?
Add Brevo types/config and deprecate usage of Sendinblue #374
Conversation
@gruberro Thank you for your contribution. This currently would be a bc break so I will keep this open for the next major release so we can merge it then. |
I think the best option without a bc break would be to add new config and a new type with called @steeven-th @gruberro what do you think? |
Sendinblue has become Brevo. |
Sounds absolut valid. Sendinblue package is abandoned, but is still working. Do you want me to rework this PR @alexander-schranz? |
If you want to work on it 👍 . In the config it will be something like: - ->scalarNode('sendinblue_api_key')->defaultValue(null)->end()
+ ->scalarNode('sendinblue_api_key')->setDeprecated(/*...*/)->defaultValue(null)->end()
+ ->scalarNode('brevo_api_key')->defaultValue(null)->end() And then keep the sendinblue part as it is and create the new brevo files. We can then add a line to the UPGRADE.md how to change from the sendinblue to brevo sdk. So people can start new projects or migrate projects already to brevo and don't get a composer deprecation message if they alread did it. |
Ok, will take care of over the next days… |
a5ec05f
to
85d2bd3
Compare
@alexander-schranz I've reworked the PR by adding Brevo and deprecating all Sendinblue thingies 😄 |
85d2bd3
to
4f1f543
Compare
@gruberro Can you also add a description in the UPGRADE.md how to switch from SendinBlue to Brevo including SQL update query for existing form with sending blue. |
@alexander-schranz I've done that, but I would really appreciate a review of the query since I don't have a good knowledge of Sulu Forms' data management. I guess the form field |
@@ -1,5 +1,25 @@ | |||
# Upgrade | |||
|
|||
## 2.5.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbd
What's in this PR?
This PR aims to replace the deprecated naming/package SendinBlue with Brevo.
Why?
Get rid of deprecation warnings and keep naming aligned with official third-party naming.
BC Breaks/Deprecations
Configuration field
sendinblue_api_key
is renamed tobrevo_api_key
. Also all internal fields are renamed. This for sure requires existing form configurations to be updated. Not sure how you would like to proceed with that kind of changes. LMK if you desire another way of refactoring.