Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor mhld_display #857

Open
jcoyne opened this issue May 8, 2023 · 1 comment
Open

Refactor mhld_display #857

jcoyne opened this issue May 8, 2023 · 1 comment
Labels
after-folio Things we'd like to cleanup or fix after FOLIO launch

Comments

@jcoyne
Copy link
Contributor

jcoyne commented May 8, 2023

Currently we do a lot of processing to get the folio data to look like the data from SIRSI. However, this could be greatly simplified if we just index the data as it appears in folio. This would require a coordinated change to the code in Searchworks that expects mhld_display to look a certain way.

@jcoyne jcoyne added the after-folio Things we'd like to cleanup or fix after FOLIO launch label May 8, 2023
@cbeer
Copy link
Member

cbeer commented May 16, 2023

I wonder if a good intermediate step would be creating an mhld_struct with some JSON in it.

{
"mhld_struct": { 
  "GREEN": {
    "STACKS": {
      "note": [],
      "holdings": [
         { "statement": "", "note": "" }
      ],
      "indexHoldings": [],
      "supplementalHoldings": [],
      "latestReceived": { "an array or a hash? not sure what data we need": "??" }
    }
  }
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
after-folio Things we'd like to cleanup or fix after FOLIO launch
Projects
None yet
Development

No branches or pull requests

2 participants