Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard against empty created/modified dates in cocina #1483

Closed
wants to merge 3 commits into from
Closed

Guard against empty created/modified dates in cocina #1483

wants to merge 3 commits into from

Conversation

thatbudakguy
Copy link
Member

Fixes #1482

jcoyne
jcoyne requested changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@jcoyne jcoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to add tests for these guards?

@thatbudakguy
Copy link
Member Author

Added tests.

@thatbudakguy thatbudakguy requested a review from jcoyne July 2, 2024 22:11
@jcoyne
Copy link
Contributor

jcoyne commented Jul 3, 2024

I think we resolved the underlying issue upstream. We shouldn't need these guards.

@thatbudakguy thatbudakguy deleted the nil-dates branch July 3, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcoyne jcoyne Awaiting requested review from jcoyne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[searchworks_traject_indexer/prod] TypeError: no implicit conversion of nil into String
2 participants
@thatbudakguy @jcoyne