Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility of multiple fields that are named the same #1096

Open
astridu opened this issue Mar 17, 2025 · 5 comments
Open

Accessibility of multiple fields that are named the same #1096

astridu opened this issue Mar 17, 2025 · 5 comments
Assignees

Comments

@astridu
Copy link

astridu commented Mar 17, 2025

SODA flagged contact emails, contributors, keywords, and related works as having multiple form fields that are named the same. Alan suggested:

  • the modal subform itself might have repeated fields... Similar to GoogleScholar, the "Contributor name" field doesn't have a label
    See this ORCID example:
Image
  • Not sure exactly how it's working, but it appears to update the label with the text entered into the field ("Test1") so that it's not flagged as missing a label
  • So to summarize what I think is going on here: any empty fields are unlabeled (axe Dev tools raises a missing label error). Once the user enters text into the field, that text becomes the field's label (no label error)
@justinlittman
Copy link
Contributor

Other than it being reported by axe, is there any evidence that this is actually an accessibility problem? I'm very reluctant to start adding more JS just to check off an accessibility checkbox.

@thatbudakguy thatbudakguy self-assigned this Mar 17, 2025
@thatbudakguy
Copy link
Member

This is the issue identified by SODA as #2254, "Label does not convey purpose of control". It's come up a few times already; Astrid ticketed this so I could pursue a solution we discussed together with Alan.

@justinlittman
Copy link
Contributor

justinlittman commented Mar 17, 2025

I think we should have evidence that this is actually an accessibility problem before putting time into it / adding additional code. Just because we can address it doesn't mean we should.

@thatbudakguy
Copy link
Member

Is SODA identifying it as "serious" not sufficient to make it an actual accessibility problem? Who else would we ask?

@justinlittman
Copy link
Contributor

Yes, that is not sufficient. SODA has a track record of one person deciding something is "serious" and then another person deciding that no change is necessary. Therefore, I think it is important that we actually understand and be able to reproduce the accessibility problem. Is this a screen reader problem? If so, how does it sound in an actual screen reader?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants