Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argo history link should link to pages for all versions #4521

Open
andrewjbtw opened this issue Jul 4, 2024 · 1 comment
Open

Argo history link should link to pages for all versions #4521

andrewjbtw opened this issue Jul 4, 2024 · 1 comment

Comments

@andrewjbtw
Copy link

The Argo item show page has a history section that lists all versions of an item. When we enable the display of previous versions, that list should link to each of the versions. Do not show a link for the version currently being viewed (system version 5 in the screenshot below):

Screenshot 2024-07-03 at 5 01 28 PM

The current click behavior of that list is odd because clicking on a title collapses the section, which can be disorienting. Instead, change the collapse behavior:

  • Add an icon for expand/collapse to the left of the version description (see wireframe)
  • Do not collapse the list when someone clicks on the title - only expand/collapse via the icon

(Figma link)

Additional notes

  • Versions that we can't render: I don't think we can show old versions that pre-date the new versioned model. If a previous version isn't available, don't put a link in the text. We'll need to communicate that limit to users. It's my understanding from planning discussion that we will be able to show old (system) versions going forward.

  • Content types: we're limiting the initial use of public versions to the "file" content type. This is largely because there are many questions around what we can render in the viewers. Argo has no viewers, so it should theoretically be possible to show old system versions regardless of content type. Please correct me if I'm wrong.

@justinlittman
Copy link
Contributor

justinlittman commented Jul 5, 2024

When did system version display get added to the scope of this WC? All of our Argo and DSA work has been on the assumption that we would be displaying user versions, but not system versions. This is a significant change in scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants