-
Notifications
You must be signed in to change notification settings - Fork 456
⬆️ Bump eslint to V9 #1071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
⬆️ Bump eslint to V9 #1071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
a7d0fc9 to
9f95831
Compare
c4570f4 to
3939102
Compare
3939102 to
df74e26
Compare
df74e26 to
4c8d6fa
Compare
Ovgodd
requested changes
Sep 5, 2025
Collaborator
Ovgodd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some clean suggestions, otherwise this is good for me !
src/frontend/apps/impress/src/features/docs/doc-management/api/useDuplicateDoc.tsx
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-management/api/useDuplicateDoc.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/service-worker/service-worker-api.ts
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/service-worker/service-worker-api.ts
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/service-worker/service-worker-api.ts
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/service-worker/service-worker.ts
Outdated
Show resolved
Hide resolved
2b5e635 to
42e4037
Compare
We upgraded ESLint to version 9 in the eslint-config-impress package. We rename it to eslint-plugin-docs.
42e4037 to
cb0f57c
Compare
|
Size Change: +2 B (0%) Total Size: 3.65 MB
|
Ovgodd
approved these changes
Sep 9, 2025
Collaborator
Ovgodd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice !
We upgraded ESLint to version 9 in the Docs app, which includes several improvements and fixes. This change also involves updating the ESLint configuration files to the new format and ensuring compatibility with the latest ESLint features.
We upgraded ESLint to version 9 in the e2e app, which includes several improvements and fixes. This change also involves updating the ESLint configuration files to the new format and ensuring compatibility with the latest ESLint features.
We upgraded ESLint to version 9 in the y-provider server, which includes several improvements and fixes. This change also involves updating the ESLint configuration files to the new format and ensuring compatibility with the latest ESLint features.
We upgraded ESLint to version 9 in the i18n package, which includes several improvements and fixes. This change also involves updating the ESLint configuration files to the new format and ensuring compatibility with the latest ESLint features.
cb0f57c to
0a1eaa3
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Version under 9 are not supported anymore better to bump it.
https://eslint.org/docs/latest/
Proposal