Skip to content

Commit 18feab1

Browse files
committed
✅(e2e) reduce flakinees
- Because of parallel test execution, some tests were flaky when using goToGridDoc, the title changed between the time we got the document list and the time we clicked on the document. - Improve addChild function.
1 parent 2777488 commit 18feab1

File tree

3 files changed

+20
-6
lines changed

3 files changed

+20
-6
lines changed

src/frontend/apps/e2e/__tests__/app-impress/doc-member-list.spec.ts

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,21 @@
11
import { expect, test } from '@playwright/test';
22

3-
import { createDoc, goToGridDoc, verifyDocName } from './utils-common';
3+
import { createDoc, verifyDocName } from './utils-common';
44
import { addNewMember } from './utils-share';
55

66
test.beforeEach(async ({ page }) => {
77
await page.goto('/');
88
});
99

1010
test.describe('Document list members', () => {
11-
test('it checks a big list of members', async ({ page }) => {
12-
const docTitle = await goToGridDoc(page);
11+
test('it checks a big list of members', async ({ page, browserName }) => {
12+
const [docTitle] = await createDoc(
13+
page,
14+
'members-big-members-list',
15+
browserName,
16+
1,
17+
);
18+
1319
await verifyDocName(page, docTitle);
1420

1521
// Get the current URL and extract the last part
@@ -73,7 +79,7 @@ test.describe('Document list members', () => {
7379
await expect(loadMore).toBeHidden();
7480
});
7581

76-
test('it checks a big list of invitations', async ({ page }) => {
82+
test('it checks a big list of invitations', async ({ page, browserName }) => {
7783
await page.route(
7884
/.*\/documents\/.*\/invitations\/\?page=.*/,
7985
async (route) => {
@@ -108,7 +114,12 @@ test.describe('Document list members', () => {
108114
},
109115
);
110116

111-
const docTitle = await goToGridDoc(page);
117+
const [docTitle] = await createDoc(
118+
page,
119+
'members-big-invitation-list',
120+
browserName,
121+
1,
122+
);
112123
await verifyDocName(page, docTitle);
113124
await page.getByRole('button', { name: 'Share' }).click();
114125

src/frontend/apps/e2e/__tests__/app-impress/doc-trashbin.spec.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ test.describe('Doc Trashbin', () => {
102102
page,
103103
browserName,
104104
docParent: subDocName,
105+
docName: 'my-trash-editor-subsubdoc',
105106
});
106107
await verifyDocName(page, subsubDocName);
107108

src/frontend/apps/e2e/__tests__/app-impress/utils-sub-pages.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,10 +72,12 @@ export const addChild = async ({
7272
page,
7373
browserName,
7474
docParent,
75+
docName,
7576
}: {
7677
page: Page;
7778
browserName: BrowserName;
7879
docParent: string;
80+
docName: string;
7981
}) => {
8082
let item = page.getByTestId('doc-tree-root-item');
8183

@@ -99,7 +101,7 @@ export const addChild = async ({
99101
await item.hover();
100102
await item.getByTestId('doc-tree-item-actions-add-child').click();
101103

102-
const [name] = randomName(docParent, browserName, 1);
104+
const [name] = randomName(docName, browserName, 1);
103105
await updateDocTitle(page, name);
104106

105107
return name;

0 commit comments

Comments
 (0)