Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name for loaded file instead of "untitled" (if not trashed in between) #1015

Closed
pikurasa opened this issue Dec 28, 2017 · 10 comments
Closed

Comments

@pikurasa
Copy link
Collaborator

wouldn't it be nice if when you opened a file and then went to save it later (without throwing anything away), instead of prompting the name "untitled" it started with the name of the file you opened?

@pikurasa
Copy link
Collaborator Author

from IRC:

(10:07:23 PM) emilyo11: the user could actually change the name of the file, or would u like the default filename to be something different, such as "My project.ly"
(10:08:16 PM) pikurasa: emilyo11: Since I save and test a lot, maybe I notice it more as an issue, but...
(10:09:23 PM) pikurasa: If I open "2017-02-11-I-tested-something.tb"... when I go to save it, I probably want to save it as "2017-02-11-I-tested-something-2.tb" or "2017-02-13-I-tested-something-again.tb"
(10:09:36 PM) pikurasa: and that would require less typing

@euanong
Copy link
Member

euanong commented Dec 28, 2017

This issue is fixed (for TB files at least) in my Planet implementation.

@pikurasa
Copy link
Collaborator Author

eohomegrownapps, does the functionality also extend to saving to Lilypond?

I could be wrong, but I expect that most people would like the name of their MB file to be the name they start with for saving to lilypond when prompted. (Of course, they may edit the name before saving.)

I suppose this idea could be extended,to saving in other formats as well (e.g. SVG etc)

@euanong
Copy link
Member

euanong commented Jan 18, 2018

As far as I know, not to LY yet - it should be quite easy to do though (saying which, it would be good to unify all the different saving functions in MB - possibly within the new Planet). I'll have a look when I get back from school.

@euanong
Copy link
Member

euanong commented Jan 22, 2018

I've fixed the issue for all file types in my new-planet branch (unifying all saving functions into SaveInterface.js) - https://github.com/eohomegrownapps/musicblocks/commits/new-planet. Testable at https://homegrownapps.tk/musicblocks/.

@walterbender
Copy link
Member

A couple of comments:
(1) Cannot we provide an open button with a link when the file is saved from the Planet?
(2) Can we add a toggle for the TB data?

@pikurasa
Copy link
Collaborator Author

(1) Cannot we provide an open button with a link when the file is saved from the Planet?

hmmm... yes, that would be nice, but what if the saved file starts to diverge from the one on the planet? Does the program detect a difference after the load and notify the user? (perhaps even point out the changes)

(2) Can we add a toggle for the TB data?

I do not understand what you have in mind for "toggle"

@pikurasa
Copy link
Collaborator Author

I put some comments on this PR that are related to this conversation.

@walterbender
Copy link
Member

if the saved file starts to diverge
In that case, the file will have been saved locally and there would be no link.

@euanong
Copy link
Member

euanong commented Jan 22, 2018

@walterbender, I should be able to do (1) and (2) when I get back from school today - the only diverge-related concern we might have is if a user saves the file and the project is republished under the same ID. Thus if a user clicked the open project button, they would see the most recently republished version, whereas if the project was opened through drag-n-drop they would see the older version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants