-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Name for loaded file instead of "untitled" (if not trashed in between) #1015
Comments
from IRC: (10:07:23 PM) emilyo11: the user could actually change the name of the file, or would u like the default filename to be something different, such as "My project.ly" |
This issue is fixed (for TB files at least) in my Planet implementation. |
eohomegrownapps, does the functionality also extend to saving to Lilypond? I could be wrong, but I expect that most people would like the name of their MB file to be the name they start with for saving to lilypond when prompted. (Of course, they may edit the name before saving.) I suppose this idea could be extended,to saving in other formats as well (e.g. SVG etc) |
As far as I know, not to LY yet - it should be quite easy to do though (saying which, it would be good to unify all the different saving functions in MB - possibly within the new Planet). I'll have a look when I get back from school. |
I've fixed the issue for all file types in my new-planet branch (unifying all saving functions into SaveInterface.js) - https://github.com/eohomegrownapps/musicblocks/commits/new-planet. Testable at https://homegrownapps.tk/musicblocks/. |
A couple of comments: |
hmmm... yes, that would be nice, but what if the saved file starts to diverge from the one on the planet? Does the program detect a difference after the load and notify the user? (perhaps even point out the changes)
I do not understand what you have in mind for "toggle" |
I put some comments on this PR that are related to this conversation. |
|
@walterbender, I should be able to do (1) and (2) when I get back from school today - the only diverge-related concern we might have is if a user saves the file and the project is republished under the same ID. Thus if a user clicked the open project button, they would see the most recently republished version, whereas if the project was opened through drag-n-drop they would see the older version. |
wouldn't it be nice if when you opened a file and then went to save it later (without throwing anything away), instead of prompting the name "untitled" it started with the name of the file you opened?
The text was updated successfully, but these errors were encountered: