fix(text)!: mark name property of type extension item as required
#495
Conversation
|
ACTION NEEDED Substrait follows the Conventional Commits The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
| @@ -10,6 +10,7 @@ properties: | |||
| items: | |||
| type: object | |||
| additionalProperties: false | |||
| required: [name] | |||
There was a problem hiding this comment.
Wouldn't structure also be required?
There was a problem hiding this comment.
Marking that field as required results in:
unknown.yaml invalid
[
{
instancePath: '/types/0',
schemaPath: '#/properties/types/items/required',
keyword: 'required',
params: { missingProperty: 'structure' },
message: "must have required property 'structure'"
}
]
There was a problem hiding this comment.
Got it. I found this paragraph on the site:
The structure field is optional. If not specified, the type class is considered to be fully opaque. This implies that a systems without built-in support for the type cannot manipulate values in any way, including moving and cloning. This may be useful for exotic, context-sensitive types, such as raw pointers or identifiers that cannot be cloned.
Sorry for the goose chase
mbrobbel
changed the title
name property of type extension item as requiredname and structure property of type extension item as required
mbrobbel
force-pushed
the
type-extension-name-required
branch
from
2309a73
to
3192890
Compare
mbrobbel
changed the title
name and structure property of type extension item as requiredname property of type extension item as required
The spec on simple extensions
states:
And for type:
However this
namefield is not marked as required on the type objectdefinition in the schema. This PR marks this field as required to make sure it
can always be referenced.