fix: remove duplication in simple extensions schema #404
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on generating deserialization code based on the simple extensions
schema in substrait-io/substrait-rs#27 I got a failing
test on extension_types.yaml.
It seems that the generated deserialization code tripped over the schema for
structure
in items in thetypes
array.Maybe I'm misunderstanding something about the schema here, but I think we can
directly use
$ref: "#/$defs/type"
forstructure
here.According to
https://json-schema.org/understanding-json-schema/reference/object.html#id5: