Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(naming): add/replace arg names in functions_boolean.yaml #317

Merged
merged 1 commit into from
Sep 8, 2022
Merged

fix(naming): add/replace arg names in functions_boolean.yaml #317

merged 1 commit into from
Sep 8, 2022

Conversation

vibhatha
Copy link
Contributor

@vibhatha vibhatha commented Sep 8, 2022

This PR adds missing arg names in the functions_boolean.yaml. I also replaced the name x to a to keep the naming consistency in the file. I have missed this when making the previous PR on bool_or and bool_and.

@vibhatha vibhatha changed the title fix: Added missing arg names in boolean functions. fix: Add missing arg names in boolean functions. Sep 8, 2022
jvanstraten
jvanstraten approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@jvanstraten jvanstraten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the letter really matters for these simple arguments, to be honest. As long as it can be referred to in a description or when you're talking about it it's fine.

@jvanstraten jvanstraten changed the title fix: Add missing arg names in boolean functions. fix(naming): add/replace arg names in functions_boolean.yaml Sep 8, 2022
@jvanstraten jvanstraten merged commit 809a2f4 into substrait-io:main Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvanstraten jvanstraten jvanstraten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vibhatha @jvanstraten