fix(naming): add missing arg names in functions_aggregate_*.yaml

[vibhatha]

This PR adds the missing argument names in functions_aggregate_approx.yaml and functions_aggregate_generic.yaml.

[vibhatha]

@jvanstraten not quite sure about the args in function

- name: "count"
    description: "Count a set of records (not field referenced)"
    impls:
      - args:
          - options: [SILENT, SATURATE, ERROR]
            required: false
        nullability: DECLARED_OUTPUT
        decomposable: MANY
        intermediate: i64
        return: i64

[jvanstraten]

The sole argument there would just be named overflow. The intended behavior of the function is to count all records when aggregating (so there's no need to reference a field) if that's what you were wondering about, but I don't really like that special case either if that's what you mean... nor do I like those functions having the same name, which is something I hadn't really considered as an option yet. But I guess that's legal because the compound names are different, so... more work for the validator :/

[vibhatha]

The sole argument there would just be named overflow. The intended behavior of the function is to count all records when aggregating (so there's no need to reference a field) if that's what you were wondering about, but I don't really like that special case either if that's what you mean... nor do I like those functions having the same name, which is something I hadn't really considered as an option yet. But I guess that's legal because the compound names are different, so... more work for the validator :/

So we could have the following for the unnamed count function?

- name: "count"
    description: "Count a set of records (not field referenced)"
    impls:
      - args:
          - name: overflow
          - options: [SILENT, SATURATE, ERROR]
            required: false
        nullability: DECLARED_OUTPUT
        decomposable: MANY
        intermediate: i64
        return: i64

[jvanstraten]

Uh, more or less, but without the - before options.

[vibhatha]

@jvanstraten updated the PR.

[vibhatha]

@jvanstraten updated the PR.