Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add variance function #263

Merged
merged 3 commits into from
Jul 28, 2022
Merged

Conversation

vibhatha
Copy link
Contributor

This PR includes the addition of variance aggregation operator.

@vibhatha vibhatha marked this pull request as ready for review July 26, 2022 04:29
@jvanstraten jvanstraten changed the title feat: Adding Variance Operator feat: add variance operator Jul 26, 2022
@jvanstraten jvanstraten changed the title feat: add variance operator feat: add variance function Jul 26, 2022
Copy link
Contributor

@jvanstraten jvanstraten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as for #257: not sure how to feel about the integer variants, and the floating point operations should use float rounding options rather than integer overflow options.

@vibhatha
Copy link
Contributor Author

Same as for #257: not sure how to feel about the integer variants, and the floating point operations should use float rounding options rather than integer overflow options.

@jvanstraten I understand. We can hold until the decision is finalized.

@jvanstraten
Copy link
Contributor

YAML CI:

functions_arithmetic.yaml invalid
[
  {
    instancePath: '/aggregate_functions/4/impls/0',
    schemaPath: '#/properties/impls/items/required',
    keyword: 'required',
    params: { missingProperty: 'intermediate' },
    message: "must have required property 'intermediate'"
  }
]

@jacques-n I forgot which earlier PR this came up in. Could that have been one of the PRs you closed yesterday, maybe? I figured it'd be in main already.

@vibhatha
Copy link
Contributor Author

@jvanstraten I updated the PR.

Copy link
Contributor

@jvanstraten jvanstraten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from:

extensions/functions_arithmetic.yaml Outdated Show resolved Hide resolved
@vibhatha
Copy link
Contributor Author

@jvanstraten updated with the suggestion.

@jvanstraten
Copy link
Contributor

Same CI issues as #257, but LGTM otherwise.

@vibhatha
Copy link
Contributor Author

@jvanstraten updated the PR, there was a typo. Let's check the CIs once again. Sorry about this.

@vibhatha
Copy link
Contributor Author

@jvanstraten I squashed the commits to a single one. Let's see the CIs.

jvanstraten
jvanstraten previously approved these changes Jul 28, 2022
@jacques-n
Copy link
Contributor

Hey @vibhatha , looks like other merges caused a merge conflict here. Can you rebase/fix?

Thanks!

@vibhatha
Copy link
Contributor Author

@jacques-n shall we go with this: #257 first and I will resolve conflicts after this.

@jacques-n
Copy link
Contributor

#257 is merged now.

@vibhatha
Copy link
Contributor Author

@jacques-n could you please check the content after rebase.

@jacques-n jacques-n merged commit b6c3772 into substrait-io:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants