Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: better explain aggregate relations #260

Merged
merged 1 commit into from
Jul 25, 2022
Merged

docs: better explain aggregate relations #260

merged 1 commit into from
Jul 25, 2022

Conversation

jvanstraten
Copy link
Contributor

@jvanstraten jvanstraten commented Jul 25, 2022 •
edited
Loading

BREAKING CHANGE: the grouping set index column now only exists if there is more
than one grouping set.

@jvanstraten
Copy link
Contributor Author

I added a bunch more explanation, including some special cases for nullability that I ran into when making the validator and the actual type of integer returned. I don't think I did a terrific job explaining, but IMO it's better than nothing until someone more used to relational algebra comes along.

@jvanstraten
Copy link
Contributor Author

Closes #258

@jvanstraten
docs: better explain aggregate relations
b144206 
BREAKING CHANGE: the grouping set index column now only exists if there is more
than one grouping set.
@jvanstraten
Copy link
Contributor Author

Apparently buf is unable to build the protos within two minutes now...? FWIW I've also seen it be ridiculously slow on my machine.

@cpcloud
Copy link
Contributor

cpcloud commented Jul 25, 2022 •
edited
Loading

The buf failure looks like an intermittent network problem, possibly related to bufbuild/buf#824.

@jvanstraten
Copy link
Contributor Author

It was hanging on the buf generate call though, so unless it was still downloading dependencies by then I don't think that was the issue just now. Weird. Add it to the pile of protobuf-related issues I suppose 🤷‍♂️

jacques-n
jacques-n approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@jacques-n jacques-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jacques-n jacques-n merged commit 42d9ca3 into substrait-io:main Jul 25, 2022
@jvanstraten jvanstraten deleted the grouping-set-index-docs branch July 26, 2022 09:41
@ingomueller-net ingomueller-net mentioned this pull request Sep 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacques-n jacques-n jacques-n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jvanstraten @cpcloud @jacques-n