feat: add aggregate function min/max support #219
Conversation
extensions/functions_arithmetic.yaml
Outdated
| - value: i8 | ||
| nullability: DECLARED_OUTPUT | ||
| decomposable: MANY | ||
| intermediate: i8 |
There was a problem hiding this comment.
Seems both the intermediate and return type should be i8?, indicating that a nullable i8.
Same applied to other impls.
There was a problem hiding this comment.
Got it. BTW do we need to define another function definication that the return type is not nullable ?
There was a problem hiding this comment.
Got it. BTW do we need to define another function definication that the return type is not nullable ? The specification shows that the functoin signature (which is the key in the yaml file) doesn't include the return type.
extensions/functions_arithmetic.yaml
Outdated
| description: Min a set of values. | ||
| impls: | ||
| - args: | ||
| - options: [ SILENT, SATURATE, ERROR ] |
There was a problem hiding this comment.
I don't see the purpose of multiple overflow behaviors for min. How would min ever overflow?
There was a problem hiding this comment.
I just got the meaning of the options which indicates the behavior of a function overflow. So will remove it.
weijietong
changed the title
|
It looks like your commit doesn't match the expected commit pattern. This is a new feature. |
weijietong
changed the title
No description provided.