Define APPROX_COUNT_DISTINCT in yaml file for approximate aggregate functions #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesRTaylor
force-pushed
the
approx-funcs
branch
from
211622f
to
888c1f0
Compare
jacques-n
reviewed
May 20, 2022
JamesRTaylor
force-pushed
the
approx-funcs
branch
from
888c1f0
to
a313dd4
Compare
|
Thanks for the review, @jacques-n. I've updated the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new yaml file for approximate function implementations, starting with defining
APPROX_COUNT_DISTINCTwhich can be found in many databases:SQL Server/Azure
Oracle
Snowflake
Spark
BigQuery
Databricks
Dremio
VoltDB
AlibabaCloud
Druid
Vertica though they name it APPROXIMATE_COUNT_DISTINCT
PrestoDB/Trino though they name it APPROX_DISTINCT