Support fractional seconds for interval_day literals #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvanstraten
force-pushed
the
interval-day-microseconds
branch
from
733d0c9
to
8b9402f
Compare
jacques-n
approved these changes
May 16, 2022
There was a problem hiding this comment.
Doh, wish this had been right to begin with rather than having a third field. Agree that third field is cleaner for compatibility. Thanks @jvanstraten
rkondakov
pushed a commit
to rkondakov/substrait
that referenced
this pull request
Nov 21, 2023
BREAKING CHANGE: RelCopyOnWriteVisitor now extends RelVisitor and has generic type parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While updating the type system documentation, I realized that
interval_dayliterals don't currently support the advertised microsecond precision. I added support via a third microseconds component in order to be completely backward-compatible.