Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flag FailureBehavior in Cast expression #186

Merged
merged 5 commits into from
May 13, 2022

Conversation

ZJie1
Copy link
Contributor

@ZJie1 ZJie1 commented May 9, 2022

No description provided.

@ZJie1 ZJie1 force-pushed the AddNullOnFailureFlag branch 2 times, most recently from 0522ae0 to 859d6a0 Compare May 9, 2022 13:20
@mbasmanova mbasmanova requested a review from jacques-n May 9, 2022 13:41
Copy link

@mbasmanova mbasmanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question.

site/docs/expressions/specialized_record_expressions.md Outdated Show resolved Hide resolved
proto/substrait/algebra.proto Outdated Show resolved Hide resolved
proto/substrait/algebra.proto Outdated Show resolved Hide resolved
proto/substrait/algebra.proto Outdated Show resolved Hide resolved
site/docs/expressions/specialized_record_expressions.md Outdated Show resolved Hide resolved
proto/substrait/algebra.proto Outdated Show resolved Hide resolved
@cpcloud
Copy link
Contributor

cpcloud commented May 13, 2022

@ZJie1 Will merge after the additional enum variant is added!

@cpcloud cpcloud changed the title Add flag nullOnFailure in Cast Expression feat: add flag FailureBehavior in Cast expression May 13, 2022
@cpcloud cpcloud merged commit a3d3b2f into substrait-io:main May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants