Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-configuration support #16

Closed
nazar-pc opened this issue Dec 6, 2023 · 3 comments · Fixed by #237
Closed

Re-configuration support #16

nazar-pc opened this issue Dec 6, 2023 · 3 comments · Fixed by #237
Labels
enhancement New feature or request good first issue Good for newcomers ux UX-related

Comments

@nazar-pc
Copy link
Member

nazar-pc commented Dec 6, 2023

There are two levels to this.

First of all currently if configuration has errors, application will show blank configuration screen, while it should populate previous values instead. No notification is shown to the user about this either. This is a bit tricky due to the fact that validity of inputs is indicated in the UI and disables "Start" button, but nothing too difficult.

✔️ Second, changing configuration is currently only possible either by editing config file directly or by deleting it and re-configuring application on restart. It should be possible to change that with UI though, even if changes are only applied after restart.

✔️ Applying changes without complete restart is a bit tricky depending on what we want to do like avoiding node restart if only farmer options changed, keeping networking stack online if both node and farmer restarted (node shutdown is non-deterministic, see paritytech/substrate#11654), adding/removing farms on the fly. It should be fairly easy to change reward address though assuming we make it Arc<something>, but not clear how common that is and whether any of this is worth the implementation complexity. Probably a button for application to restart itself is sufficient here.

@nazar-pc nazar-pc added enhancement New feature or request good first issue Good for newcomers ux UX-related labels Dec 6, 2023
@nazar-pc
Copy link
Member Author

Basic configuration changes are possible with #25

@nazar-pc
Copy link
Member Author

With #26 it will be possible to show a restart button and restart the whole app

@nazar-pc
Copy link
Member Author

With #237 we'll have ability to open configuration with old configuration of unknown validity and move from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers ux UX-related
Projects
Status: Complete
Development

Successfully merging a pull request may close this issue.

1 participant