You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all currently if configuration has errors, application will show blank configuration screen, while it should populate previous values instead. No notification is shown to the user about this either. This is a bit tricky due to the fact that validity of inputs is indicated in the UI and disables "Start" button, but nothing too difficult.
✔️ Second, changing configuration is currently only possible either by editing config file directly or by deleting it and re-configuring application on restart. It should be possible to change that with UI though, even if changes are only applied after restart.
✔️ Applying changes without complete restart is a bit tricky depending on what we want to do like avoiding node restart if only farmer options changed, keeping networking stack online if both node and farmer restarted (node shutdown is non-deterministic, see paritytech/substrate#11654), adding/removing farms on the fly. It should be fairly easy to change reward address though assuming we make it Arc<something>, but not clear how common that is and whether any of this is worth the implementation complexity. Probably a button for application to restart itself is sufficient here.
The text was updated successfully, but these errors were encountered:
There are two levels to this.
First of all currently if configuration has errors, application will show blank configuration screen, while it should populate previous values instead. No notification is shown to the user about this either. This is a bit tricky due to the fact that validity of inputs is indicated in the UI and disables "Start" button, but nothing too difficult.
✔️ Second, changing configuration is currently only possible either by editing config file directly or by deleting it and re-configuring application on restart. It should be possible to change that with UI though, even if changes are only applied after restart.
✔️ Applying changes without complete restart is a bit tricky depending on what we want to do like avoiding node restart if only farmer options changed, keeping networking stack online if both node and farmer restarted (node shutdown is non-deterministic, see paritytech/substrate#11654), adding/removing farms on the fly. It should be fairly easy to change reward address though assuming we make it
Arc<something>
, but not clear how common that is and whether any of this is worth the implementation complexity. Probably a button for application to restart itself is sufficient here.The text was updated successfully, but these errors were encountered: