Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to max out the drive rather than guessing the max size #115

Closed
nazar-pc opened this issue Feb 4, 2024 · 2 comments · Fixed by #269
Closed

Allow to max out the drive rather than guessing the max size #115

nazar-pc opened this issue Feb 4, 2024 · 2 comments · Fixed by #269
Assignees
Labels
backend Backend logic enhancement New feature or request farmer Farmer functionality frontend Frontend/user interface ux UX-related

Comments

@nazar-pc
Copy link
Member

nazar-pc commented Feb 4, 2024

Space Acres allows to specify the size for the farm, but there are a few UX issues:

  • if you specify the size that is larger than available space on disk, it will fail to start and there is no nice recovery from this situation right now (see Re-configuration support #16)
  • it takes a few attempts to actually guess the max size without exceeding disk size

As such it would be nice to support an option to fill the whole drive and let the app figure out how big the size should be for that to happen.

The strategy could be pretty simple:

  • start with the farm size that is equal to size of the drive -1GiB
  • if that fails, go down 1GiB at a time until it farm allocation succeeds

In config we can store None until farm size is known, after which it will be replaced with a fixed value identified during farm startup.

@nazar-pc
Copy link
Member Author

There was an idea on a call yesterday that we should support filling the disk while leaving some amount of space free. I think it merges nicely with this issue, where this issue originally described a special case of leaving 0 bytes free.

@nazar-pc
Copy link
Member Author

nazar-pc commented Aug 5, 2024

So I think we should have two options:

  • Fixed size (current logic)
  • % of free space (where 100% means the whole disk is used)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend logic enhancement New feature or request farmer Farmer functionality frontend Frontend/user interface ux UX-related
Projects
Status: Complete
Development

Successfully merging a pull request may close this issue.

1 participant