-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No autocomplete with C# (OmniSharp Roslyn) #661
Comments
No completion: I see this issue on the language server's repo: OmniSharp/omnisharp-roslyn#1554 Document not updating: Perhaps you can see if the server is not logging errors in response to any didChange notifications? Hover error: I can't see the response, but judging by the error it might be invalid - something like: |
After enabling the debug log I get this. This is the initialization messages:
The log does not contain the word There are also no occurrences of the |
The full log can be found here: https://git.sr.ht/~troels/Log/tree/master/log.log |
Thanks for the log, it confirms the completion issue as well as why buffer changes are not communicated - the server turns it off ( The first issue I linked explains the problem with the omnisharp server - if it turns out this package is responsible for the incomplete capabilities then I'll gladly have a look! |
How can I check that? I have just checked with the same LSP in Neovim (via CoC). Both To be honest I don't know much about the LSP protocol. Coc.nvim touts itself as being compatible with vscode. I don't know if that means that there is the protocol and then there is a non-standard vscode implementation. I saw that the issue you linked to links to another issue, which has been solved. I guess it ought to be solved. |
I also have this issue. |
The fix for the issues was merged in a related project (csharp-language-server-protocol), but I believe the reference to that project hasn't been updated in omnisharp-roslyn itself. Hopefully a maintainer will comment in their issue (#1554) when that's been released. LSP follows the protocol, but avoids some complexities like dynamic registration of capabilities. It's possible CoC and VSCode use dynamic registration and therefore don't experience this issue. |
Any updates on this? I tried OmniSharp too, but didn't really get anywhere. Some points of interest:
|
I just tried with the latest release 1.34.2. Still the same. |
A new issue was created for the TextDocumentSync here: OmniSharp/csharp-language-server-protocol#162. Although an incomplete fix was added, new bugs appeared, and the related package also needs to be updated to the omnisharp-roslyn repo itself. Perhaps someone wants to contribute some tests that cover non-dynamic-registration :) I'll add some documentation for this server as I found it to be pretty quick to set up otherwise! |
It has improved a bit with the release of 1.34.3. There is still no |
I wondered if this was a recent regression, but even 1.32.9 turns off textDocumentSync for static capabilities. Either way, they merged a fix to the protocol library 3 days ago, so perhaps the next release of omnisharp-roslyn will get this working! |
The LSP only works partially.
It has to major problems:
No autocompletion from the LSP only the built in from Sublime appears, even though I have explicitly disabled it in the LSP settings.
It does not reload when I edit the buffer (so only initial analysis). If I delete a line and then hover over a symbol beneath it, it gives me the old line, indicating again that the LSP does not accommodate to the buffer's contents.
I don't think it is an LSP problem, since it works fine in Neovim.
OS and language server
I use Arch Linux and the latest release of the OmniSharp Roslyn language server (1.34)
How you installed LSP (Package Control or from git?)
I installed the development version via cloning the git repository and then satisfying dependencies from within Sublime.
Minimal reproduction steps
The following is an excerpt from the log. It does not log anything when I try to trigger autocomplete.
The text was updated successfully, but these errors were encountered: