Skip to content
This repository has been archived by the owner on Sep 21, 2024. It is now read-only.

Release workflow incorrectly overwrites existing release binaries #615

Open
cdata opened this issue Aug 29, 2023 · 0 comments
Open

Release workflow incorrectly overwrites existing release binaries #615

cdata opened this issue Aug 29, 2023 · 0 comments
Labels
Bug Incorrect or unexpected behavior Chore Non-user-facing feature

Comments

@cdata
Copy link
Collaborator

cdata commented Aug 29, 2023

We have occasionally dealt with botched releases where release-please is confused about which version it is releasing. It attempts to re-release a version that has been released. For the most part this is side-effect free, but there is at least one exception: release artifacts on the Github release may be changed. And, in the case of our Swift package, this can cause the SHA in Package.swift to no longer match the one on the Github release.

We should remedy this by making sure that we don't re-upload artifacts if a release is already created prior to the release workflow.

@cdata cdata added Bug Incorrect or unexpected behavior Chore Non-user-facing feature labels Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Incorrect or unexpected behavior Chore Non-user-facing feature
Projects
Status: 🏔️ Icebox
Development

No branches or pull requests

1 participant