Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular velocity in RIGID_PITCHING movement does not contain the Phase parameter #1654

Closed
HL-ZHI opened this issue Jun 3, 2022 · 2 comments
Labels

Comments

@HL-ZHI
Copy link
Contributor

HL-ZHI commented Jun 3, 2022

Describe the bug
When I employed the pitching movement, I found the angular velocity has something wrong. So I checked the code of grid movement (can be seen in SU2/COMMON/src/grid_movement/CVolumetricMovement.cpp, line 2069). It seems the expression of angular velocity does not contain the initial phase.

At line 2063-2065, we can see that the expression of pitching angle considers the initial phase, like, "angle=Ampl * sin(Omega * Time + Phase)". Therefore, shouldn't the angular velocity is "AlphaDot = Omega * Ampl * cos(Omega *Time + Phase)" ? However, there is no Phase parameter in the expressions at line 2069-2071. I think it is a small bug.

Desktop (please complete the following information):

  • SU2 Version: [v7.3.1]
@HL-ZHI HL-ZHI added the bug label Jun 3, 2022
@pcarruscag
Copy link
Member

I think you are right, thank you for looking into it. Can you open a pull request with the fix?

@HL-ZHI
Copy link
Contributor Author

HL-ZHI commented Jun 4, 2022

I think you are right, thank you for looking into it. Can you open a pull request with the fix?

Thank you for your reply. I have submitted my pull request at #1656. It is my first time to use github, hope I didn't make a mistake :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants