Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axisymmetry for SA is not implemented #1565

Open
bigfooted opened this issue Mar 18, 2022 · 7 comments
Open

Axisymmetry for SA is not implemented #1565

bigfooted opened this issue Mar 18, 2022 · 7 comments

Comments

@bigfooted
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is and what you expect the behavior to be instead. If applicable, add screenshots to help explain your problem.

2D axisymmetry source terms for the SA turbulence model are not implemented. There is also no warning/error to the user.

@bigfooted bigfooted added the bug label Mar 18, 2022
@pcarruscag pcarruscag changed the title axisymmetry for SA not implemented Axisymmetry for SA is not implemented Mar 19, 2022
@TobiKattmann
Copy link
Contributor

An error for SA+axissymmetry is introduced in #1571. So this then now labels as a feature-request :)

@WallyMaier
Copy link
Contributor

If anyone has a source for this, Id be interested in adding this.

@bigfooted
Copy link
Contributor Author

@WallyMaier I don't have a reference showing the specific terms for SA, but you can derive it from the general transformation from Cartesian to cylindrical coordinates. It looks like the only term that is affected is the diffusion term. The appendix of Transport Phenomena (Bird, Stewart, Lightfoot) shows some Cartesian and cylindrical forms for a general scalar transport equation.
The result is that the divergence of a flux in Cartesian coordinates is
$$(1/r) * (d/dr)(rJ_x) + (1/r)(d/d theta)(J_{theta}) + d/dz(J_z)$$
and we neglect the theta-term in axisymmetric flow.

@stale stale bot added the stale label Jul 10, 2022
@su2code su2code deleted a comment from stale bot Jul 10, 2022
@stale stale bot removed the stale label Jul 10, 2022
@stale
Copy link

stale bot commented Nov 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still a relevant issue please comment on it to restart the discussion. Thank you for your contributions.

@stale stale bot added the stale label Nov 2, 2022
@bigfooted
Copy link
Contributor Author

@pcarruscag pcarruscag removed the stale label Nov 2, 2022
@stale
Copy link

stale bot commented Jan 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still a relevant issue please comment on it to restart the discussion. Thank you for your contributions.

@pcarruscag
Copy link
Member

Now it's implemented but it's missing the curvature correction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants