Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace PhantomJS with headless Chrome #473

Closed
sapegin opened this issue Jun 7, 2017 · 5 comments · Fixed by #616
Closed

Replace PhantomJS with headless Chrome #473

sapegin opened this issue Jun 7, 2017 · 5 comments · Fixed by #616

Comments

@sapegin
Copy link
Member

sapegin commented Jun 7, 2017

We have a script that loads a production build of a style guide and checks that there’s no JavaScript errors. We run in on Travis CI to check that production bundles actually work.

Now the script uses PhantomJS which has some issues like always out of date WebKit version and most likely it will not be supported anymore.

The new headless Chrome looks like a better and future friendly alternative.

There are wrappers like that should make interaction with Chrome easier.

@n1313
Copy link
Collaborator

n1313 commented Jun 12, 2017

@sapegin
Copy link
Member Author

sapegin commented Jun 12, 2017

Haha, I forget to link it in the latest sentence ;-)

@sapegin
Copy link
Member Author

sapegin commented Aug 29, 2017

There’s even better candidate: https://github.com/GoogleChrome/puppeteer

@devsnek
Copy link
Contributor

devsnek commented Sep 28, 2017

I can have a PR for this done in a few hours if no one else is interested

@sapegin
Copy link
Member Author

sapegin commented Sep 28, 2017

@devsnek Sounds great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants