-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve terminal output on style guide server start #470
Labels
Comments
Take a look at CRA implementation (link in the description), they have all the code (and we probably can reuse it). |
That's exacly the code I have use, I just need to get the ip address of the
computer
…On Sun, 11 Jun 2017, 10:49 a.m. Artem Sapegin, ***@***.***> wrote:
Take a look at CRA implementation (link in the description), they have all
the code (and we probably can reuse it).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#470 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABALdQzlBLjLnKbkoO3eDzr6COG4O6hBks5sC7g1gaJpZM4Nyshn>
.
|
Le copy and le paste shall be made then :p
…---
Thank You and Best regards
Sara Vieira
Front End Developer
http://iamsaravieira.com
http://twitter.com/NikkitaFTW
On Sun, 11 Jun 2017 at 13:00 Artem Sapegin < mailto:Artem Sapegin <[email protected]> > wrote:
a, pre, code, a:link, body { word-wrap: break-word !important; }
But they already have it ;-/
https://github.com/facebookincubator/create-react-app/blob/dc4ce606ef8b4c97aec0c80c20f8116e9795bb21/packages/react-dev-utils/WebpackDevServerUtils.js#L38-L88
—
You are receiving this because you commented.
Reply to this email directly,
#470 (comment)
, or
https://github.com/notifications/unsubscribe-auth/ABALdS6uHv0saRmloztiGGBopPGqWamkks5sC9bZgaJpZM4Nyshn
.
|
Try to reuse their code first ;-) |
Looks cool! Could we remove this
|
Sure! I'll create a branch and start working on this tonight :)
…On Sun, 11 Jun 2017, 7:07 p.m. Artem Sapegin, ***@***.***> wrote:
Looks cool! Could we remove this npm run compile notice? It’s incorrect
anyway ;-)
- Style guide → style guide
- On Your Network → On your network
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#470 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABALddtXf2bJaOt9DWUhly_pc-L_0d98ks5sDCzcgaJpZM4Nyshn>
.
|
Sounds good, thanks! 🍕 |
@SaraVieira Do you have anything to pull request here? ;-) |
snmslavk
added a commit
to snmslavk/react-styleguidist
that referenced
this issue
Aug 29, 2017
snmslavk
added a commit
to snmslavk/react-styleguidist
that referenced
this issue
Aug 29, 2017
snmslavk
added a commit
to snmslavk/react-styleguidist
that referenced
this issue
Aug 29, 2017
… message; remove redundant parameters condition
snmslavk
added a commit
to snmslavk/react-styleguidist
that referenced
this issue
Aug 29, 2017
This was referenced Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I like how it’s done in Create React App:
Most likely we can reuse some functions from react-dev-utils (we already use it in Styleguidist), then this task will be relatively easy ;-)
The text was updated successfully, but these errors were encountered: