Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing build crashes styleguide dev server (and doesn't output errors) #1847

Closed
tomas-hartman opened this issue Jun 25, 2021 · 1 comment
Closed
Labels

Comments

@tomas-hartman
Copy link

Current behavior

Styleguidist's dev server does not output errors into terminal and needs to be fully restarted if build fails. It often happens after a silly mistake such as "const variable =" and it is very annoying, because when I make such mistake before I build styleguide, I have no error output at all and no notification that the build failed. I noticed that this might be caused by my packages and their dependencies that we use in our project.

To reproduce

I was able to create repro of the crash when build fails, but I was not able to reproduce the output not coming to the terminal (I did not focus that much on this part, since it is covered in #1822).

git clone https://github.com/tomas-hartman/example.git
git checkout bug
npm install
npm run start

# 1. wait for 'compiled successfully'
# 2. go to src/components/Button.tsx and uncomment L36, save and let styleguide rebuild
# 3. check localhost:6060 (blank page with error in browser console)
# 4. comment L36 and save
# 5. dev server crashed, no rebuild happened

Expected behavior

Everything should work exactly like in master branch of the example:

  1. I expect that I don't need to restart dev-server after trivial build fail
  2. I expect that all errors are still outputed into terminal (not visible in enclosed repro)

I suppose that this might be caused by mutually incompatible dependencies, but I am not sure of that.
It also might be related to #1822, #1785 and (perhaps) #1703.

@tomas-hartman tomas-hartman changed the title Build fail crashes styleguide dev server (and doesn't show errors) Failing build crashes styleguide dev server (and doesn't output errors) Jun 25, 2021
@stale
Copy link

stale bot commented Oct 2, 2021

😴 This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week without any further activity. Consider opening a pull request if you still have this issue or want this feature.

@stale stale bot added the wontfix label Oct 2, 2021
@stale stale bot closed this as completed Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant