Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hot reloading broken on windows #1246

Closed
dbrelovsky opened this issue Jan 11, 2019 · 2 comments
Closed

hot reloading broken on windows #1246

dbrelovsky opened this issue Jan 11, 2019 · 2 comments

Comments

@dbrelovsky
Copy link

Current behavior

Hot reloading is not working on a windows machine for all versions after 7.3.7.

I tracked it down to this change: #1133
On my machine all paths produced by getComponentFiles contain forward slashes as separator (in v7.3.8) and backslashes in v7.3.7.

If I change

const componentFiles = getFilesMatchingGlobs(componentGlobs, rootDir, ignore)

to

const componentFiles = getFilesMatchingGlobs(componentGlobs, rootDir, ignore).map(f => path.resolve(f));

hot reloading works again.

@sapegin
Copy link
Member

sapegin commented Jan 14, 2019

Feel free to send a pull request with a fix 👾

@styleguidist-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 9.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants