Skip to content

Commit 649cc4c

Browse files
shyamjvsk8s-publish-robot
authored andcommitted
Modify traces in deletion handler
Kubernetes-commit: c4ca2c734963afd442ff6c43631d004092ea74e8
1 parent ded52ff commit 649cc4c

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

pkg/endpoints/handlers/rest.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -987,10 +987,11 @@ func DeleteResource(r rest.GracefulDeleter, allowsOptions bool, scope RequestSco
987987
scope.err(fmt.Errorf("decoded object cannot be converted to DeleteOptions"), w, req)
988988
return
989989
}
990+
trace.Step("Decoded delete options")
990991

991-
trace.Step("About to record audit event")
992992
ae := request.AuditEventFrom(ctx)
993993
audit.LogRequestObject(ae, obj, scope.Resource, scope.Subresource, scope.Serializer)
994+
trace.Step("Recorded the audit event")
994995
} else {
995996
if values := req.URL.Query(); len(values) > 0 {
996997
if err := metainternalversion.ParameterCodec.DecodeParameters(values, scope.MetaGroupVersion, options); err != nil {
@@ -1002,8 +1003,8 @@ func DeleteResource(r rest.GracefulDeleter, allowsOptions bool, scope RequestSco
10021003
}
10031004
}
10041005

1006+
trace.Step("About to check admission control")
10051007
if admit != nil && admit.Handles(admission.Delete) {
1006-
trace.Step("About to check admission control")
10071008
userInfo, _ := request.UserFrom(ctx)
10081009

10091010
err = admit.Admit(admission.NewAttributesRecord(nil, nil, scope.Kind, namespace, name, scope.Resource, scope.Subresource, admission.Delete, userInfo))

0 commit comments

Comments
 (0)