From 69667524b135a449458b039afcf29fe164acd610 Mon Sep 17 00:00:00 2001
From: Santos Gallegos <santos_g@outlook.com>
Date: Thu, 27 Jun 2019 15:28:32 -0500
Subject: [PATCH] Remove calls to assign from django guardian

This is related to #5853
---
 readthedocs/builds/models.py   | 3 ---
 readthedocs/projects/forms.py  | 3 ---
 readthedocs/projects/models.py | 3 ---
 3 files changed, 9 deletions(-)

diff --git a/readthedocs/builds/models.py b/readthedocs/builds/models.py
index 1039b815326..e0569d6ca1e 100644
--- a/readthedocs/builds/models.py
+++ b/readthedocs/builds/models.py
@@ -13,7 +13,6 @@
 from django.utils.translation import ugettext
 from django.utils.translation import ugettext_lazy as _
 from django_extensions.db.models import TimeStampedModel
-from guardian.shortcuts import assign
 from jsonfield import JSONField
 from polymorphic.models import PolymorphicModel
 from taggit.managers import TaggableManager
@@ -246,8 +245,6 @@ def save(self, *args, **kwargs):  # pylint: disable=arguments-differ
         """Add permissions to the Version for all owners on save."""
         from readthedocs.projects import tasks
         obj = super().save(*args, **kwargs)
-        for owner in self.project.users.all():
-            assign('view_version', owner, self)
         broadcast(
             type='app',
             task=tasks.symlink_project,
diff --git a/readthedocs/projects/forms.py b/readthedocs/projects/forms.py
index 416b2e7c5df..e7e03b59dae 100644
--- a/readthedocs/projects/forms.py
+++ b/readthedocs/projects/forms.py
@@ -11,7 +11,6 @@
 from django.template.loader import render_to_string
 from django.utils.safestring import mark_safe
 from django.utils.translation import ugettext_lazy as _
-from guardian.shortcuts import assign
 from textclassifier.validators import ClassifierValidator
 
 from readthedocs.core.utils import slugify, trigger_build
@@ -484,8 +483,6 @@ def clean_user(self):
 
     def save(self):
         self.project.users.add(self.user)
-        # Force update of permissions
-        assign('view_project', self.user, self.project)
         return self.user
 
 
diff --git a/readthedocs/projects/models.py b/readthedocs/projects/models.py
index e4c90e1e72d..c4521411d00 100644
--- a/readthedocs/projects/models.py
+++ b/readthedocs/projects/models.py
@@ -15,7 +15,6 @@
 from django.utils.functional import cached_property
 from django.utils.translation import ugettext_lazy as _
 from django_extensions.db.models import TimeStampedModel
-from guardian.shortcuts import assign
 from six.moves import shlex_quote
 from taggit.managers import TaggableManager
 
@@ -421,8 +420,6 @@ def save(self, *args, **kwargs):  # pylint: disable=arguments-differ
             if not self.slug:
                 raise Exception(_('Model must have slug'))
         super().save(*args, **kwargs)
-        for owner in self.users.all():
-            assign('view_project', owner, self)
         try:
             latest = self.versions.filter(slug=LATEST).first()
             default_branch = self.get_default_branch()