-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depreciation of this Package #30
Comments
Thanks for maintaining this project and helping us get converted to CRA+TypeScript! It's great news that a broader community is interested in this support existing in CRA. Hope to see you around the net in the future! |
Has anyone managed to migrate to the new CRA with Typescript support (v2.1+) ? Removing the rewrite causes hundreds of errors in my project, as if the
If I try to still use the rewrite with the newest version if fails too: /home/feimosi/Projects/saycaster-podcatcher/frontend/node_modules/
react-app-rewire-typescript-babel-preset/dist/rewireWebpack.js:22
throw new Error("Unable to locate scripts loader."); Any suggestions? |
Can you try the |
I've tried but turns out react-scripts overrides |
After I upgraded the You can check both my Hope it could help to solve your issue. |
We also migrated successfully. We're currently using [email protected] with the following {
"compilerOptions": {
"allowJs": true,
"allowSyntheticDefaultImports": true,
"esModuleInterop": true,
"forceConsistentCasingInFileNames": true,
"isolatedModules": true,
"jsx": "Preserve",
"lib": ["DOM", "DOM.Iterable", "ES2018"],
"module": "ESNext",
"moduleResolution": "Node",
"noEmit": true,
"noFallthroughCasesInSwitch": true,
"noImplicitAny": false,
"noImplicitReturns": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"pretty": true,
"resolveJsonModule": true,
"skipLibCheck": false,
"strict": true,
"target": "ES5"
}
} |
I can't get it working because CRA forces certain tsconfig values i.e. Also, @josephj @seniorquico do you have local absolute imports working with your configs? I don't see |
@feimosi https://blogs.msdn.microsoft.com/typescript/2018/08/27/typescript-and-babel-7/ We do not use absolute imports. There are some CRA discussion threads on this topic: facebook/create-react-app#5692 |
@seniorquico that's interesting about Anyway, thanks for the links! |
@feimosi I'm sorry, I have no idea! 🤷♂️ I haven't encountered that error. 😞 |
Hello,
Thank you everyone for your support and interest in this package.
I will be adding a depreciated banner to this repository as soon as the pull request below is released. Let me know if you have any questions or concerns.
Create React App adds TypeScript Support
There is a pending pull request to add TypeScript support (through the Babel preset) to Create React App which you can view here:
facebook/create-react-app#4837. I was able to swap out this rewire for a build of Create React App with TypeScript support.
The first post has instructions on how to try the new build out. For testing purposes, it was recommended to build the branch and use Yarn's link feature.
It looks like it is very close to release. It may be worth waiting for the official release.
If you're interesting in adding the build to your project without linking, you can try the following (Yarn instructions):
babel-preset-react-app
andreact-scripts
to a folder in your workspace:Create React App v2 Release Notes
You can view the blog post here: https://reactjs.org/blog/2018/10/01/create-react-app-v2.html
Migration instructions from alpha:
https://gist.github.com/gaearon/8650d1c70e436e5eff01f396dffc4114
Monorepo support (from 2.x alphas) was removed in final 2.0
The decision to drop monorepo support is detailed here: https://gist.github.com/gaearon/8650d1c70e436e5eff01f396dffc4114#monorepo-support-from-2x-alphas-was-removed-in-final-20
Files from before monorepo support removal
webpack.config.dev.js
https://github.com/facebook/create-react-app/blob/22353ecf02db21f7bff6a0c088ef7f0631f29fd6/packages/react-scripts/config/webpack.config.dev.js#L219
paths.js
https://github.com/facebook/create-react-app/blob/22353ecf02db21f7bff6a0c088ef7f0631f29fd6/packages/react-scripts/config/paths.js
workspaceUtils.js
https://github.com/facebook/create-react-app/blob/22353ecf02db21f7bff6a0c088ef7f0631f29fd6/packages/react-dev-utils/workspaceUtils.js
The text was updated successfully, but these errors were encountered: