-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation warnings caused by node-byline dependency #7
Comments
@mistic thanks for the heads up. I'll see what I can find. |
Cool, thanks for the link. After I posted I did a little searching and was happy to see several uses outside of the original strong-supervisor usage. It looks like your usage pattern is the most common one. I'll add some ANSI escape codes to some tests to make sure that colourizing things is treated as first-class usage. |
@rmg thank you very much for taking care of this! |
@mistic published as |
@rmg thank you very much for the quick fix on this! |
@rmg @sam-github On node 10 I'm having deprecation warnings using
strong-log-transformer
due to it'snode-byline
dependency usage of the nodeBuffer
api. I've already opened a PR againstnode-byline
(jahewson/node-byline#53) in order to fix those problems, but the library seems to be very unmaintained so far, so I don't think if the PR will ever get merged and released.In case that happens it might be a good idea try to replace this
node-byline
with other with the same needed features.The text was updated successfully, but these errors were encountered: