Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promisify relation/scope methods in juggler #2709

Closed
sundeepgupta opened this issue Sep 4, 2016 · 4 comments
Closed

Promisify relation/scope methods in juggler #2709

sundeepgupta opened this issue Sep 4, 2016 · 4 comments

Comments

@sundeepgupta
Copy link

If I define a model with a custom scope like this:

  "scopes": {
    "active": {
      "where": {
          "status": "active"
      }
    }
  }

When I call it from client code MyModel.active(), this does not return a promise, it requires a callback argument.

@jannyHou
Copy link
Contributor

jannyHou commented Sep 8, 2016

@sundeepgupta the scope functions are not promisified yet. I will label this issue as a feature to keep track of the status of Promisify relation/scope methods in juggler. Thanks for bringing it up.
And here is a placeholder shows what apis we already promisified: #418

@jannyHou jannyHou self-assigned this Sep 8, 2016
@coodoo coodoo mentioned this issue Sep 8, 2016
32 tasks
@jannyHou jannyHou changed the title Custom scopes defined in the JSON file are not promisfied Promisify relation/scope methods in juggler Sep 8, 2016
@sundeepgupta
Copy link
Author

thanks @jannyHou

@stale
Copy link

stale bot commented Sep 9, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot closed this as completed Sep 23, 2017
@stale
Copy link

stale bot commented Sep 23, 2017

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants