From 8f42096402426793a9a69f94bd80bf4c93f53ba2 Mon Sep 17 00:00:00 2001 From: David Brownman Date: Mon, 29 Sep 2025 23:39:07 -0700 Subject: [PATCH 1/4] update supported versions --- .github/workflows/ci.yml | 5 +++-- README.md | 8 +++++++- src/Stripe.net/Stripe.net.csproj | 4 ++-- 3 files changed, 12 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 519bca2d17..f3fe246a04 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -32,9 +32,10 @@ jobs: - name: Setup .NET uses: actions/setup-dotnet@v1 with: + # see: https://docs.stripe.com/sdks/versioning?server=dotnet#stripe-sdk-language-version-support-policy + # even numbers are LTS + # TODO: add 9.0.x; https://go/j/RUN_DEVSDK-1957 dotnet-version: | - 2.1.x - 3.1.x 5.0.x 6.0.x 7.0.404 diff --git a/README.md b/README.md index da01bae1ee..8def094b06 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ [![Build Status](https://github.com/stripe/stripe-dotnet/actions/workflows/ci.yml/badge.svg?branch=master)](https://github.com/stripe/stripe-dotnet/actions?query=branch%3Amaster) [![Coverage Status](https://coveralls.io/repos/github/stripe/stripe-dotnet/badge.svg?branch=master)](https://coveralls.io/github/stripe/stripe-dotnet?branch=master) -The official [Stripe][stripe] .NET library, supporting .NET Standard 2.0+, .NET Core 3.1+, and .NET Framework 4.6.1+. +The official [Stripe][stripe] .NET library, supporting .NET Standard 2.0+, .NET Core 4+, and .NET Framework 4.6.2+. ## Installation @@ -35,6 +35,12 @@ From within Visual Studio: 5. Click on the Stripe.net package, select the appropriate version in the right-tab and click _Install_. +### Requirements + +Per our [Language Version Support Policy](https://docs.stripe.com/sdks/versioning?server=dotnet#stripe-sdk-language-version-support-policy), we currently support **.NET Standard 2.0+, .NET Core 4+, and .NET Framework 4.6.2+.**. + +Support for .NET Core versions 5 & 7 are deprecated and will be removed in the next major version. Support for version 6 will be removed in a future version. Read more and see the full schedule in the docs: https://docs.stripe.com/sdks/versioning?server=dotnet#stripe-sdk-language-version-support-policy + ## Documentation For a comprehensive list of examples, check out the [API diff --git a/src/Stripe.net/Stripe.net.csproj b/src/Stripe.net/Stripe.net.csproj index 6177a581d3..994989f688 100644 --- a/src/Stripe.net/Stripe.net.csproj +++ b/src/Stripe.net/Stripe.net.csproj @@ -1,11 +1,11 @@  - Stripe.net is a sync/async client and portable class library for the Stripe API, supporting .NET Standard 2.0+, .NET Core 3.1+, and .NET Framework 4.6.1+. (Official Library) + Stripe.net is a sync/async client and portable class library for the Stripe API, supporting .NET Standard 2.0+, .NET Core 4+, and .NET Framework 4.6.2+. (Official Library) 48.5.0 8 Stripe, Jayme Davis - net5.0;net6.0;net7.0;net8.0;netcoreapp3.1;netstandard2.0;net461 + net5.0;net6.0;net7.0;net8.0;netstandard2.0;net462 stripe;payment;credit;cards;money;gateway;paypal;braintree icon.png https://github.com/stripe/stripe-dotnet From 92b7592667cc48deb6faf724b8c2b30a82500d72 Mon Sep 17 00:00:00 2001 From: David Brownman Date: Mon, 29 Sep 2025 23:56:35 -0700 Subject: [PATCH 2/4] update some strings --- .../Infrastructure/Public/SystemNetHttpClient.cs | 4 ++-- src/Stripe.net/Services/_base/Service.cs | 8 ++++---- src/Stripe.net/Stripe.net.csproj | 2 +- src/StripeTests/StripeTests.csproj | 4 ++-- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/Stripe.net/Infrastructure/Public/SystemNetHttpClient.cs b/src/Stripe.net/Infrastructure/Public/SystemNetHttpClient.cs index 0f09dfe936..0ae0e6b157 100644 --- a/src/Stripe.net/Infrastructure/Public/SystemNetHttpClient.cs +++ b/src/Stripe.net/Infrastructure/Public/SystemNetHttpClient.cs @@ -37,8 +37,8 @@ public class SystemNetHttpClient : IHttpClient "netcoreapp3.1" #elif NETSTANDARD2_0 "netstandard2.0" -#elif NET461 - "net461" +#elif NET462 + "net462" #else #error "Unknown target framework" #endif diff --git a/src/Stripe.net/Services/_base/Service.cs b/src/Stripe.net/Services/_base/Service.cs index 70f8f02052..3ec055a9d8 100644 --- a/src/Stripe.net/Services/_base/Service.cs +++ b/src/Stripe.net/Services/_base/Service.cs @@ -132,7 +132,7 @@ internal IEnumerable ListRequestAutoPaging( where T : IStripeEntity { var apiMode = ApiModeUtils.GetApiMode(url); -#if NET461 +#if NET462 if (apiMode == ApiMode.V2) { return @@ -153,7 +153,7 @@ internal IEnumerable ListRequestAutoPaging( #endif } -#if NET461 +#if NET462 internal IEnumerable V1ListRequestAutoPagingSync( string url, ListOptions options, @@ -427,7 +427,7 @@ internal IEnumerable SearchRequestAutoPaging( RequestOptions requestOptions) where T : IStripeEntity { -#if NET461 +#if NET462 return this.SearchRequestAutoPagingSync(url, options, requestOptions); #else @@ -436,7 +436,7 @@ internal IEnumerable SearchRequestAutoPaging( #endif } -#if NET461 +#if NET462 private IEnumerable SearchRequestAutoPagingSync( string url, SearchOptions options, diff --git a/src/Stripe.net/Stripe.net.csproj b/src/Stripe.net/Stripe.net.csproj index 994989f688..2d59492f41 100644 --- a/src/Stripe.net/Stripe.net.csproj +++ b/src/Stripe.net/Stripe.net.csproj @@ -65,7 +65,7 @@ - + diff --git a/src/StripeTests/StripeTests.csproj b/src/StripeTests/StripeTests.csproj index c24c46d98b..1553453170 100644 --- a/src/StripeTests/StripeTests.csproj +++ b/src/StripeTests/StripeTests.csproj @@ -1,7 +1,7 @@ - net5.0;net6.0;net7.0;net8.0;netcoreapp3.1;netcoreapp2.1;net461 + net5.0;net6.0;net7.0;net8.0;net462 8 true false @@ -28,7 +28,7 @@ - + From 34b8a22b97805493b20386b23c92134fe733f4c4 Mon Sep 17 00:00:00 2001 From: David Brownman Date: Tue, 30 Sep 2025 09:46:35 -0700 Subject: [PATCH 3/4] pr feedback --- README.md | 4 ++-- .../Infrastructure/Public/SystemNetHttpClient.cs | 2 +- src/Stripe.net/Services/_base/Service.cs | 8 ++++---- src/Stripe.net/Stripe.net.csproj | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/README.md b/README.md index 8def094b06..57b466f41f 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ [![Build Status](https://github.com/stripe/stripe-dotnet/actions/workflows/ci.yml/badge.svg?branch=master)](https://github.com/stripe/stripe-dotnet/actions?query=branch%3Amaster) [![Coverage Status](https://coveralls.io/repos/github/stripe/stripe-dotnet/badge.svg?branch=master)](https://coveralls.io/github/stripe/stripe-dotnet?branch=master) -The official [Stripe][stripe] .NET library, supporting .NET Standard 2.0+, .NET Core 4+, and .NET Framework 4.6.2+. +The official [Stripe][stripe] .NET library, supporting .NET Standard 2.0+, .NET Core 5+, and .NET Framework 4.6.2+. ## Installation @@ -37,7 +37,7 @@ From within Visual Studio: ### Requirements -Per our [Language Version Support Policy](https://docs.stripe.com/sdks/versioning?server=dotnet#stripe-sdk-language-version-support-policy), we currently support **.NET Standard 2.0+, .NET Core 4+, and .NET Framework 4.6.2+.**. +Per our [Language Version Support Policy](https://docs.stripe.com/sdks/versioning?server=dotnet#stripe-sdk-language-version-support-policy), we currently support **.NET Standard 2.0+, .NET Core 5+, and .NET Framework 4.6.2+.**. Support for .NET Core versions 5 & 7 are deprecated and will be removed in the next major version. Support for version 6 will be removed in a future version. Read more and see the full schedule in the docs: https://docs.stripe.com/sdks/versioning?server=dotnet#stripe-sdk-language-version-support-policy diff --git a/src/Stripe.net/Infrastructure/Public/SystemNetHttpClient.cs b/src/Stripe.net/Infrastructure/Public/SystemNetHttpClient.cs index 0ae0e6b157..e20758de46 100644 --- a/src/Stripe.net/Infrastructure/Public/SystemNetHttpClient.cs +++ b/src/Stripe.net/Infrastructure/Public/SystemNetHttpClient.cs @@ -40,7 +40,7 @@ public class SystemNetHttpClient : IHttpClient #elif NET462 "net462" #else -#error "Unknown target framework" +#warning "Unknown target framework" #endif ; diff --git a/src/Stripe.net/Services/_base/Service.cs b/src/Stripe.net/Services/_base/Service.cs index 3ec055a9d8..62e72aef4a 100644 --- a/src/Stripe.net/Services/_base/Service.cs +++ b/src/Stripe.net/Services/_base/Service.cs @@ -132,7 +132,7 @@ internal IEnumerable ListRequestAutoPaging( where T : IStripeEntity { var apiMode = ApiModeUtils.GetApiMode(url); -#if NET462 +#if NETFRAMEWORK if (apiMode == ApiMode.V2) { return @@ -153,7 +153,7 @@ internal IEnumerable ListRequestAutoPaging( #endif } -#if NET462 +#if NETFRAMEWORK internal IEnumerable V1ListRequestAutoPagingSync( string url, ListOptions options, @@ -427,7 +427,7 @@ internal IEnumerable SearchRequestAutoPaging( RequestOptions requestOptions) where T : IStripeEntity { -#if NET462 +#if NETFRAMEWORK return this.SearchRequestAutoPagingSync(url, options, requestOptions); #else @@ -436,7 +436,7 @@ internal IEnumerable SearchRequestAutoPaging( #endif } -#if NET462 +#if NETFRAMEWORK private IEnumerable SearchRequestAutoPagingSync( string url, SearchOptions options, diff --git a/src/Stripe.net/Stripe.net.csproj b/src/Stripe.net/Stripe.net.csproj index 2d59492f41..04ec02b9e0 100644 --- a/src/Stripe.net/Stripe.net.csproj +++ b/src/Stripe.net/Stripe.net.csproj @@ -1,7 +1,7 @@  - Stripe.net is a sync/async client and portable class library for the Stripe API, supporting .NET Standard 2.0+, .NET Core 4+, and .NET Framework 4.6.2+. (Official Library) + Stripe.net is a sync/async client and portable class library for the Stripe API, supporting .NET Standard 2.0+, .NET Core 5+, and .NET Framework 4.6.2+. (Official Library) 48.5.0 8 Stripe, Jayme Davis From c3911ef4a2f38e9571a0062d71b4809ccf7dfe53 Mon Sep 17 00:00:00 2001 From: David Brownman Date: Tue, 30 Sep 2025 09:57:12 -0700 Subject: [PATCH 4/4] remove unused dep --- src/Stripe.net/Stripe.net.csproj | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/Stripe.net/Stripe.net.csproj b/src/Stripe.net/Stripe.net.csproj index 04ec02b9e0..9a266e3380 100644 --- a/src/Stripe.net/Stripe.net.csproj +++ b/src/Stripe.net/Stripe.net.csproj @@ -56,10 +56,6 @@ - - - -